Fixes #94 by replacing function getCovariateDataSubset #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdemeulder With the latest results data (9 data sources), I do still get warnings from data.tables. I think because of the sheer size of the data. But at least the issue of duplication of demographics data should be solved with this fix. |
|
I get the following error in the cohort characteriazation tab. The numbers have changed though, (from close to 60M rows down to 550K rows), so I guess your fix did that. |
|
@bdemeulder Indeed. It seems there are two issues, one on the shiny side and one on the data side. This PR only fixed the shiny side of things |
bdemeulder
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Somehow the function
getCovariateDataSubsetwas misbehaving. This function was used in two places, where I added the subsetting logic directly.NOTE: this removes the ability to retrieve results from DB storage. As far as I know we were not using this anyway, as we read all premerged results from an
.Rdatafile.