Erbui sdmmc support #693
Merged
Erbui sdmmc support #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmtech-rdi
force-pushed
the
erbui-sdmmc-support
branch
from
8504027 to
50f4ec5
Compare
VCV needs -municode for build, which defines TCHAR as wchar_t while FatFs also defines this type to char. So we have a global namespace name clash we can't solve without changing FatFs implementation (which is available as a dependency inside libdaisy). We therefore remove the test and support for Windows.
ohmtech-rdi
force-pushed
the
erbui-sdmmc-support
branch
from
50f4ec5 to
a2525bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SD with FatFs support to ERB.
Warning
Support of this feature is not available on Windows, and probably never will (see details below)
VCV makefile on Windows include the
-municodeflag to GCC compile command. This will in turn define automatically new types, such asTCHARthat is then set towchar_t(instead ofcharin the ANSI/OEM version).Unfortunately, FatFs also defines this type, and since we have
#define _LFN_UNICODE 0inffconf.hprovided in libDaisy, FatFs will try (and fail) to define theTCHARtype aschar.To solve this, we would need to isolate the source code to make sure our implementation of the FatFs wrapper is not compiled with
-municode, but this is asking for troubles. Rather we don't support it on Window and will assess a potential correction some time in the future.