You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the HTTPClient.wait() method is defined but not used anywhere.
The method seems to handle timeouts. However, currently the timeout paramter is directly passed to requests, and timeouts are handled as expected. Therefore, I think the method and corresponding tests can be removed.
The text was updated successfully, but these errors were encountered:
Alright, makes sense. Would have probably helped to read the code properly :)
I will add a description of this use case in the docs in #49 and provide full unit tests in #52. And I will close the open PR as that is relying on false assumptions.
(But I will leave this issue open until the docs and unit tests are addressed)
It seems that the
HTTPClient.wait()
method is defined but not used anywhere.The method seems to handle timeouts. However, currently the timeout paramter is directly passed to
requests
, and timeouts are handled as expected. Therefore, I think the method and corresponding tests can be removed.The text was updated successfully, but these errors were encountered: