Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grunt deploy and/or grunt serve (or similar) #10

Closed
taoeffect opened this issue Mar 25, 2016 · 1 comment · Fixed by #1939
Closed

Add grunt deploy and/or grunt serve (or similar) #10

taoeffect opened this issue Mar 25, 2016 · 1 comment · Fixed by #1939

Comments

@taoeffect
Copy link
Member

taoeffect commented Mar 25, 2016

Problem

We'll at some point need to be able to deploy GI to a running server.

Solution

Background:

  • Right now we have grunt dev as the only way of serving the app.
  • We also have an open issue for chel serve which is the ideal way that this issue would be closed
  • A temporary alternative to chel serve would be implementing grunt serve - the idea of which would be to serve an optimized production build of the app.

I think whether we do chel serve or grunt serve first, we need a command to generate a build of the app that is production optimized. Currently we only generate a development build.

So a possible route forward would be to:

  • Implement a grunt deploy command that uses esbuild to create a production bundle of the app
  • Then implement grunt serve <folder> that just runs the server on port 8000 by default (and not browsersync). Make sure to take into account the contracts folder (perhaps grunt deploy would copy the contracts folder into a directory containing the groupincome bundle).
    • Note: chel serve is essentially the same thing, but more difficult to implement because the chel command doesn't have the Chelonia server in it (that's still here in Group Income under the backend/ folder)

Old Commentary/notes

See:

EDIT: Another possibility is making it possible install a groupincome command via npm install -g and running that.

The point is our current approach of running grunt dev is not appropriate for deploying to a server, and we need something simpler and without the overhead of grunt dev.

@taoeffect taoeffect self-assigned this Aug 7, 2018
@taoeffect taoeffect removed their assignment Oct 3, 2023
@taoeffect taoeffect changed the title Add grunt deploy Add grunt deploy (or similar) Oct 3, 2023
@taoeffect taoeffect changed the title Add grunt deploy (or similar) Add grunt deploy or grunt serve (or similar) Mar 23, 2024
@taoeffect taoeffect changed the title Add grunt deploy or grunt serve (or similar) Add grunt deploy and/or grunt serve (or similar) Mar 23, 2024
@taoeffect
Copy link
Member Author

@Silver-IT keep in mind that there is now a releases branch that will contain each release of the website (including the contracts) and this will be what grunt serve will be serving...

@Silver-IT Silver-IT linked a pull request Apr 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants