Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two grunt commands #1939

Merged
merged 26 commits into from
May 7, 2024

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT self-assigned this Apr 18, 2024
@Silver-IT Silver-IT linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link

cypress bot commented Apr 18, 2024

Passing run #2208 ↗︎

0 111 8 0 Flakiness 0

Details:

Merge 3130bb6 into 7368f3f...
Project: group-income Commit: 55bf2dbdf2 ℹ️
Status: Passed Duration: 09:48 💡
Started: May 2, 2024 9:44 PM Ended: May 2, 2024 9:54 PM

Review all test suite changes for PR #1939 ↗︎

backend/database.js Outdated Show resolved Hide resolved
frontend/main.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review

backend/database.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really solid @Silver-IT! Just two change requests left, and then once these are applied I will go ahead and test the PR and see how everything works.

Gruntfile.js Outdated Show resolved Hide resolved
frontend/main.js Outdated Show resolved Hide resolved
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Great work @Silver-IT !! 👏 👏

@taoeffect taoeffect merged commit 40b6e48 into master May 7, 2024
4 checks passed
@taoeffect taoeffect deleted the 10-add-grunt-deploy-andor-grunt-serve-or-similar branch May 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grunt deploy and/or grunt serve (or similar)
3 participants