#1811 - Wrong file attachment detection in the chatroom #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a todo comment for future <submit-button /> replacement * add submit-button component to various places * work on Greg's CR
…1748) * render welcome screen as position:fixed in /pending-approval page * make the selector higher priority
…when-user-clicks-name-in-payments Show user profile cards when user clicks name in payments
* feat: direct messages in identity contract * feat: add/remove getters * feat: simplified getters * wip: merging privateDMs and groupDMs * fix: coding issues * feat: UI updates for the DMs with more than 3 * fix: add member to dm * feat: changed base branch from e2e-protocol-ricardo to e2e-protocol * fix: error in get dm by usernames * chore: added comments * fix: error in function parameters declaration * fix: inconsistent naming of members when create a new DM * fix: redundant message rendering issue * feat: grun tpin * chore: removed wrong version of contracts * feat: grunt pin:0.1.8 * feat: added comments * chore: removed changes in chelonia * chore: added comments * chore: fix typo * feat: error handling * chore: removed unnecessary comment * feat: improved chatroom types and added comments * feat: simplified getter * chore: simplified * chore: added comments, error handling * fix: error to save scroll position * chore: removed allowDMInvite
Bugfix: key rotation on watched contracts
contract was re-synced
…tocol-branch Make Cypress test passing for E2E protocol
#926 Create a PWA for the app
…annel-btn #1790 - Remove the extra space in "Add to channel" button
…in-electron Fix for a cypress failure related to push-subscription in Electron
* Remove dontBroadcast parameter * Rename subscribersByContractID to subscribersByChannelID * Rename contractID to channelID in pubsub * Move defaultOptions to the top * Emit an event upon successful sub * Use the new sub event to sync contracts * Fix logging of 'Already subscribed to' messages * Rename SUCCESS to OK * Add createOkResponse and remove createResponse * Add basic pub implementation * No longer broadcast UNSUB upon close event * Replace 'contract' by 'channel' where appropriate * Revert usage of the new ??= operator * Improve subscription-succeeded handler * Use force to sync contracts upon reconnection * Disallow subscribing to unknown channels * Remove shared/logger.js
* replace theme_color field in manifest.json file to the equivalent meta tag * update status-bar color according to the theme-setting change
* add a sbp selector for manually updating the service-worker * call Registration.update() immediately / set up 1hr periodic timer for it * remove useless console.log * check WebSocket.CLOSED / WebSocket.CLOSING before sending message to the push-server * set up a event listener for PUBSUB_RECONNECTION_SUCCEEDED sbp event * fix the typo * minor updates
* implment [PUB] message handler in server-side pubsub * create various pubsub related actions in chatroom.js action handlers * make sure 'chatroom-user-typing' pubsub event works correctly * add handler for pubsub event PUBSUB_EVENT_TYPE.CHATROOM_USER_TYPING in SendArea.vue * delete a duplicate component method * throttle the pubsub event-emitter function * move the typing indicator position * implement CHATROOM_USER_STOP_TYPING event for when the textarea field is emptied * do not unsub/sub from the chatroom contract pubsub channel / use the existing channel to emit a message * fix the UI bug in the chatroom / remove all console.log * revert the block in backend/pubsub.js where it adds a channel if not exist * detach GI specific message handlers from chelonia / pubsub * revert the default PUB message handler to the shared.pubsub.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1811