Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server signature validation #1871

Merged
merged 16 commits into from
Mar 8, 2024
Merged

Server signature validation #1871

merged 16 commits into from
Mar 8, 2024

Conversation

corrideat
Copy link
Member

No description provided.

@corrideat corrideat marked this pull request as draft February 27, 2024 21:11
@cypress Cypress
Copy link

cypress bot commented Feb 27, 2024 •
edited
Loading

Passing run #1950 ↗︎

0 110 8 0 Flakiness 0

Details:

Merge e06c8d0 into 245b667...
Project: group-income Commit: 02314c06ac ℹ️
Status: Passed Duration: 11:21 💡
Started: Mar 8, 2024 10:21 AM Ended: Mar 8, 2024 10:33 AM

Review all test suite changes for PR #1871 ↗︎

taoeffect
taoeffect reviewed Feb 28, 2024
View reviewed changes
backend/routes.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Feb 28, 2024
View reviewed changes
backend/routes.js Outdated Show resolved Hide resolved
@corrideat corrideat marked this pull request as ready for review February 28, 2024 18:05
taoeffect
taoeffect reviewed Feb 28, 2024
View reviewed changes
backend/server.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Feb 28, 2024
View reviewed changes
backend/server.js Outdated Show resolved Hide resolved
@corrideat corrideat mentioned this pull request Mar 1, 2024
Merged
taoeffect

This comment was marked as off-topic.

Sign in to view

taoeffect
taoeffect reviewed Mar 4, 2024
View reviewed changes
backend/server.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Mar 6, 2024
View reviewed changes
backend/routes.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Mar 6, 2024
View reviewed changes
backend/server.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Mar 8, 2024
View reviewed changes
backend/server.js Outdated Show resolved Hide resolved
taoeffect
taoeffect approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @corrideat! 🎉

@taoeffect taoeffect merged commit 64e8a2b into master Mar 8, 2024
4 checks passed
@taoeffect taoeffect deleted the server-signature-validation branch March 8, 2024 10:44
Silver-IT
Silver-IT reviewed Mar 12, 2024
View reviewed changes
shared/domains/chelonia/utils.js
Comment on lines +282 to +291
const decryptedKeyResult = unwrapMaybeEncryptedData(key.meta.private.content)
// Unable to decrypt
if (!decryptedKeyResult) continue
// Data aren't encrypted
if (decryptedKeyResult.encryptionKeyId == null) {
throw new Error('Expected encrypted data but got unencrypted data for key with ID: ' + key.id)
}
decryptedKey = decryptedKeyResult.data
decryptedKeys.push([key.id, decryptedKey])
storeSecretKey(key, decryptedKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be the reason of the following error.

https://okturtles.slack.com/archives/C0EH7P20Y/p1710209299493659

@taoeffect taoeffect mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silver-IT Silver-IT Silver-IT left review comments

@taoeffect taoeffect taoeffect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corrideat @taoeffect @Silver-IT