Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap UserID for Username while editing text #1886

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Swap UserID for Username while editing text #1886

merged 1 commit into from
Mar 15, 2024

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT self-assigned this Mar 14, 2024
@Silver-IT Silver-IT linked an issue Mar 14, 2024 that may be closed by this pull request
Fix identityContractIDs showing up in edit field mentions #1867
Closed
@cypress Cypress
Copy link

cypress bot commented Mar 14, 2024

Passing run #1975 ↗︎

0 110 8 0 Flakiness 0

Details:

Merge b35701f into d7aa2d7...
Project: group-income Commit: 0faaf32b03 ℹ️
Status: Passed Duration: 10:48 💡
Started: Mar 14, 2024 8:32 AM Ended: Mar 14, 2024 8:43 AM

Review all test suite changes for PR #1886 ↗︎

corrideat
corrideat approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@corrideat corrideat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Perhaps for a different PR, I'd consider:

  1. splitting messages into parts (e.g., text and mentions) so that regular expressions are not needed
  2. diplaying mentions in the send / edit areas as rich text instead of plain text.

taoeffect
taoeffect approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well, great job @Silver-IT!

@taoeffect taoeffect merged commit d0e4f6d into master Mar 15, 2024
4 checks passed
@taoeffect taoeffect deleted the 1867-fix-identitycontractids-showing-up-in-edit-field-mentions branch March 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corrideat corrideat corrideat approved these changes

@taoeffect taoeffect taoeffect approved these changes

Assignees

@Silver-IT Silver-IT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix identityContractIDs showing up in edit field mentions
3 participants
@Silver-IT @taoeffect @corrideat