#2414 - "See proposal" link should always lead to proposal #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2414-see-proposal-link-bug
|
| Run status |
|
| Run duration | 09m 12s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
corrideat
reviewed
Nov 14, 2024
| const targetEl = this.$refs.pList.querySelector(`[data-proposal-hash="${targetId}"]`) | ||
|
|
||
| targetEl && targetEl.scrollIntoView({ block: 'center' }) | ||
| }, 150) |
There was a problem hiding this comment.
Is there a way to do this without a timeout?
There was a problem hiding this comment.
The delay is actually not necessary here. So replaced it with nextTick() instead.
taoeffect
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2414
I realised there is a same issue in this in-app notification UI too, so made a fix there as well.