#2429 - File attachment in chat should show the size #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2429-file-should-show-size
|
| Run status |
|
| Run duration | 08m 45s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
reviewed
Nov 27, 2024
| @@ -67,6 +68,7 @@ export const messageType: any = objectMaybeOf({ | |||
| attachments: arrayOf(objectOf({ | |||
| name: string, | |||
| mimeType: string, | |||
| size: optional(numberRange(1, CHAT_ATTACHMENT_SIZE_LIMIT)), | |||
There was a problem hiding this comment.
Some observations:
- Not all messages have attachments, but all attachments have a file size, right? So I think maybe it makes sense to make the
arrayOfon line 68optional, and make this size here mandatory. - Since
CHAT_ATTACHMENT_SIZE_LIMITcould change in the future and even be an admin configurable value, let's make this valueNumber.MAX_SAFE_INTEGERinstead.
taoeffect
requested changes
Dec 2, 2024
frontend/views/utils/filters.js
Outdated
| @@ -15,6 +15,17 @@ export const getFileType = ( | |||
| return mimeType.match('image/') ? 'image' : 'non-image' | |||
| } | |||
|
|
|||
| export const formatBytesDecimal = (bytes: number, decimals: number = 2): string => { | |||
| if (bytes === 0) { return '0 Bytes' } | |||
There was a problem hiding this comment.
I would add some other checks here:
if (bytes < 0 || !Number.isFinite(bytes)) return 'Invalid size'
frontend/views/utils/filters.js
Outdated
| export const formatBytesDecimal = (bytes: number, decimals: number = 2): string => { | ||
| if (bytes === 0) { return '0 Bytes' } | ||
|
|
||
| const k = 1000 // Decimal base |
There was a problem hiding this comment.
I think this should be 1024, as 1024 bytes = 1KB
| arrayOf(objectOf({ | ||
| name: string, | ||
| mimeType: string, | ||
| size: optional(numberRange(1, Number.MAX_SAFE_INTEGER)), |
There was a problem hiding this comment.
Can you check if we always provide this size info now? If so, this should probably no longer be optional.
… sebin/task/#2429-file-should-show-size
…le-should-show-size
|
Updated the PR again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works on #2429
There are currently two UIs for files attached to a message:
[case 1] General one - size is displayed next to the file format.
[case 2] Image preview - size is displayed as part of the tooltip text when hovered over the download button.
But please let me know if you have different ideas for them.