-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed tooltip position on mobile #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks for your first PR @Vayras!
I found a bug - please be sure to thoroughly test all PRs and check the console for errors, in this case there's an issue with bottom-center
not being a valid Tooltip
direction:
I recommend also testing with dummy data, you can temporarily modify GroupMembersActivity.vue
to use dummy data to test the display.
@taoeffect thanks for the review I will fix this 🚀 |
@taoeffect I have fixed the direction property can you please review this again for me? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has the same problem.
@Vayras If you take a look at direction: {
type: String,
validator: (value) => ['bottom', 'bottom-left', 'bottom-right', 'right', 'left', 'top', 'top-left'].includes(value),
default: 'bottom'
}, If you need other values, you need to modify |
@corrideat thanks for the info I looked at the file and found an attribute "bottom-middle" which is as you said the default attribute as well so I'm using that |
@Vayras What file are you seeing that in? I don't see that in any file in the project. |
@corrideat Thanks for the heads up I think I was referring to the wrong tooltip file, fixed that in the latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work in my tests, great job @Vayras!
issue: #2434
fixed the tooltip position on mobile