#2457 - Fix the broken blockquotes in the chat markdown #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2457-blockquote-not-working
|
| Run status |
|
| Run duration | 11m 26s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Nice work @SebinSong!
Found one issue related to empty paragraph breaks in blockquotes.
Markdown:
> Test
And
> `another () => test` of the
>
> ```
> emergency () => system
> ```
>
> But what about
> Paragraph breaks
> That are empty
>
> Like this one
() => testGroup Income:
Github:
Test
And
another () => testof theemergency () => systemBut what about
Paragraph breaks
That are emptyLike this one
() => test
|
@taoeffect Improved the PR with additional fix. 
|
taoeffect
requested changes
Dec 16, 2024
There was a problem hiding this comment.
EDIT: I can also save this for a separate issue to fix if you'd prefer!
Interesting... it seems the logic for @mentions and channel name mentions is a bit wonky too, as sometimes it works, and sometimes it doesn't:
Markdown:
> @u1 Test #general
And
> `another () => test` of the
>
> ```
> emergency () => system
> and
>
> break
> ```
>
> But what about
> Paragraph breaks
> That are empty
>
> Like this one @u1 #general
() => testResult:
Github (checking to see if it handles @U1...):
@U1 Test #general
And
another () => testof theemergency () => system and breakBut what about
Paragraph breaks
That are emptyLike this one @U1 #general
() => test
taoeffect
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2457
[ Fix screenshot ]
Made sure this fix does not revert the fix for #2130 too.