Improvements to time syncing

[corrideat]

Closes #2485.

[taoeffect]

Left one comment. Also consider, is there any useful console.info (or higher level) debugging that should be added anywhere to help diagnose the issue?

[cypress]

group-income    Run #3654

Run Properties:   Passed #3654  •  fab129db05 ℹ️: Merge 15546731b752c0ff62823127337f544e482f2e89 into 160bb6231efbcee1834b96106dc0...

Project	group-income
Branch Review	2485-group-inactivity-still-shows-the-wrong-inactive-members-lastloggedin-bug
Run status	Passed #3654
Run duration	10m 40s
Commit	fab129db05 ℹ️: Merge 15546731b752c0ff62823127337f544e482f2e89 into 160bb6231efbcee1834b96106dc0...
Committer	Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	10
Skipped	0
Passing	112
View all changes introduced in this branch ↗︎

[corrideat]

is there any useful console.info (or higher level) debugging that should be added anywhere to help diagnose the issue?

I don't think so, but I also think this issue is resolved. If you want to test these changes locally, you're gonna need two devices (or a VM). You should carry out these steps on master to reproduce the issue and on this branch.

I recommend using Firefox on the device that will be suspended (device B) and running the server on device A. The reason to use Firefox is that you can follow these instructions to test locally without HTTPS.

1. Change LAST_LOGGED_IN_THROTTLE_WINDOW in constants.js to a small value, like 2 minutes. Also, change lastLoggedIn to type: PERIODIC_NOTIFICATION_TYPE.MIN1 in mainNotificationMixin.js. This is not strictly necessary but will make testing a lot faster.
2. Register on device A and create a group. Add income details (not necessary, but you can see the activity tab in the UI).
3. Join the group on device B as a new user. Also add income details.
4. Close the app in device A.
5. Put device B to sleep for at least the time you set in LAST_LOGGED_IN_THROTTLE_WINDOW. You may need to do this a few times.
6. On master, you should eventually miss the entry for the user created in device A. On this branch, you shouldn't miss any entries.

[taoeffect]

Nice! Congrats @corrideat !