Add utils to measure portal's uptime #71
Conversation
Add utils
bcbernardo
added
the
analysis
bcbernardo
added this to the Relatório do Censo 2020 - 100 mil habitantes || Census Report 2020 - 100k inhabitants milestone
|
|
||
| Os utilitários contidos nesse sub-repositório podem ser instalados como pacotes | ||
| Python avulsos. Para isso, você deve ter instalada na sua máquina uma versão | ||
| Python compatível (3.7 ou superior). |
There was a problem hiding this comment.
I see you use typing.Final in the code, but typing.Final was introduced in Python 3.8. There's also a Python 3.7y reference in setup.cfg.
VALITATION-GUIDE.md
Outdated
| @@ -0,0 +1,320 @@ | |||
| # Guia de validação | |||
There was a problem hiding this comment.
Shouldn't this file be named VALIDATION-GUIDE.md? I guess VALIDATION might be a typo.
| @@ -0,0 +1,36 @@ | |||
| # Environment variables | |||
|
|
|||
| ### IMPORTANT: when done editing this file, rename it to ".env" | |||
There was a problem hiding this comment.
You might want to take a look in Createnv to easily automate that.
Disclaimer: I am the creator of that package! But, I mean… I wrote it exactly to make it easy to onboard newcomers to projects using .env files ✨
| @@ -0,0 +1,20 @@ | |||
| # Copyright 2020 Open Knowledge Brasil | |||
| from kaggle.api.kaggle_api_extended import KaggleApi # type: ignore | ||
| from kaggle.models.kaggle_models_extended import Metadata # type: ignore |
There was a problem hiding this comment.
# type: ignore tells linters to ignore these lines, but tells nothing to fellow developers about why you are importing this here (and not in the top of the file as usual). What about a friendly comment here to help fellow coders?
Should close #41