Adding Interactive Map with cases #14

ellisonleao · 2018-10-10T21:22:37Z

Ref #5

Questions:

Are the lat/lng numbers going to be added on the base spreadsheet or should we get them inside the serialize_cases function?
Are we going to use custom marker icons ?
What information should the marker popups have?

I've opened the pull request with some already things changed, which includes:

creating new /map route
added a link to the map route on top of the cases list
created initial map (no markers yet)

cuducos · 2018-10-11T11:23:41Z

Are the lat/lng numbers going to be added on the base spreadsheet or should we get them inside the serialize_cases function?

By now I think we could get them when processing the spreadsheet — unless until we find a better solution. My rational for that is that converting city names to geo-coordinates is a task that looks like more proper for machines (serialize_cases) than humans. The alternative would be to have a third tab/spreadsheet with all the coordinates of all Brazilian cities. What do you think, @turicas?

Are we going to use custom marker icons ?

Not at this point, but we can implement it later ; )

What information should the marker popups have?

Suggestion: the headline of case.main_story?

One more suggestion: I see no need for victims/static/map.css – This coded could be inside victims/static/styles.css with no harm IMHO ; )

* upstream/master: (25 commits) Add codecov.yml Add meta tags for social media Add codcov Python package Enhance visibility for footer logos Format Python code with Black Strong the order Fix when sort (reverse) Run black Add paragraph Randomize stories inside each case Round robin cases by aggressor_side Add agressor_side to Case fix footer Mobile styles Typo: gray -> grey Add success message to clear cache script Fix quotes on Google Analytics code Move other project links to about page Add about page Add tag color ...

* upstream/master: Add Docker for production Small tweak for big displays Simplify font-size add font math thanks to https://css-tricks.com/snippets/css/fluid-typography/ Transform flex istead of changing to block on footer style

* upstream/master: Use HTTP in metatags Fix og:image (full URL) Fix og:image Makes Sanic enforce HTTPS Change FOSS messge at the bottom Remove Agência Pública's spreadsheet link

* upstream/master: Add sample spreadsheet Cleanup Refactor Data class Escape HTML chars

ellisonleao · 2018-10-11T21:36:59Z

@cuducos the changes you've asked are already made, i am just waiting for the new spreadsheet template so i can update the data model and add the markers on frontend.

Also, i am not sure if it would be better to squash all commits into a single one at the end.

turicas · 2018-10-11T23:33:10Z

@ellisonleao you can just add a column called "latlon" to "Casos" spreadsheet and collect data from there (it's going to be a list of floats on the model).

* upstream/master: Add links to the about page Format Python code with Black Update methodology

ellisonleao · 2018-10-12T03:32:20Z

@turicas are we going to use | as separator for the float numbers, just like we have for tags? e.g:-12.12|5.34

turicas · 2018-10-12T03:42:33Z

@ellisonleao I think the best would be "," because:
1- Numbers will not have "," inside them (but tags could have) since the decimal separator is "."; and
2- A lot of geolocation systems use "," so we can easily copy and paste.

ellisonleao · 2018-10-12T05:52:05Z

@cuducos @turicas i've added the markers code and the serialization of the latlon field. What extra information do you think we need on the maps page? Right now there is only the map and the button for the cases form.

One probably issue is that we will need to group the cases by city/state in order for all them to show if we have multiple cases in the same city. Maybe a property function in the Cases data model could take care of getting that data correct

cuducos · 2018-10-15T19:15:07Z

Maybe a property function in the Cases data model could take care of getting that data correct

I think this sounds like a good way of implementing it.

I tried to run your branch but it throws a NameError: name 'cached' is not defined in victims/__init__.py and there are some tests failing. So I'm afraid I can test anything further ATM. But let me know if you need anything else.

* master:

* master: limit story description. Ref #24 Force close Redis connections Replace aiocache by aioredis Remove REDIS_DB envvar

- adding latlon column on cases fixtur

cuducos · 2018-10-17T18:45:03Z

victims/data.py

+            # serializing  latitude and longitude
+            data["latlng"] = data["latlng"].strip() or ""
+            data["latlng"] = data["latlng"].split(",")
+            data["latlng"] = list(map(float, data["latlng"]))


I think this is slightly more readable, what do you think?

Suggested change

data["latlng"] = list(map(float, data["latlng"]))

data["latlng"] = [float(coord) for coord in data["latlng"]]

BTW if this column is empty this line breaks the app… we might need something for this edge case ; )

Yes! I've started by adding some try/exceptions for ValueError exceptions but i am not sure what you guys prefer.

ellisonleao · 2018-10-18T00:19:01Z

I think this sounds like a good way of implementing it.

actually i am not sure right now if adding a function over there will be the best. Is there a unique element that we can use as the aggregator for same city cases (latlng, city, etc) ? What about just adding that logic to aggregate the cases by city in the map route function for now?

baralhao · 2018-10-18T00:36:22Z

hi guys

I made a dashboard with map and some informations. I will appreciate your feedback.

cya
eduardo medeiros

http://bit.ly/VitimasIntolerancia

adding initial map route and template. Ref #5

f059e79

cuducos added the work in progress label Oct 11, 2018

ellisonleao added 5 commits October 11, 2018 10:29

Merge remote-tracking branch 'upstream/master' into feat/issue-5

06dfa98

* upstream/master: Use HTTP in metatags Fix og:image (full URL) Fix og:image Makes Sanic enforce HTTPS Change FOSS messge at the bottom Remove Agência Pública's spreadsheet link

limit map bounds to brazil

92a1277

Merge remote-tracking branch 'upstream/master' into feat/issue-5

30da7a7

* upstream/master: Add sample spreadsheet Cleanup Refactor Data class Escape HTML chars

cuducos force-pushed the master branch from 39b42e7 to 7e08247 Compare October 11, 2018 22:08

turicas force-pushed the master branch from 7e08247 to eb4fe35 Compare October 11, 2018 22:52

Merge remote-tracking branch 'upstream/master' into feat/issue-5

75056f0

* upstream/master: Add links to the about page Format Python code with Black Update methodology

showing markers on map. serializing latlng field

dcb2cb0

ellisonleao changed the title ~~(Do not merge) Adding Interactive Map with cases~~ Adding Interactive Map with cases Oct 12, 2018

ocefpaf mentioned this pull request Oct 13, 2018

Create a map using LeaftLet #5

Open

ellisonleao added 4 commits October 15, 2018 17:41

Merge branch 'master' into feat/issue-5

220fbac

* master:

Merge branch 'master' into feat/issue-5

30a2ada

* master: limit story description. Ref #24 Force close Redis connections Replace aiocache by aioredis Remove REDIS_DB envvar

fixing tests

5935163

- adding latlon column on cases fixtur

adding map tests, fix map route function

bfd9bc6

cuducos reviewed Oct 17, 2018

View reviewed changes

ellisonleao closed this Jun 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Interactive Map with cases #14

Adding Interactive Map with cases #14

ellisonleao commented Oct 10, 2018

cuducos commented Oct 11, 2018

ellisonleao commented Oct 11, 2018 •

edited

Loading

turicas commented Oct 11, 2018

ellisonleao commented Oct 12, 2018 •

edited

Loading

turicas commented Oct 12, 2018

ellisonleao commented Oct 12, 2018 •

edited

Loading

cuducos commented Oct 15, 2018

cuducos Oct 17, 2018

cuducos Oct 17, 2018

ellisonleao Oct 17, 2018 •

edited

Loading

ellisonleao commented Oct 18, 2018 •

edited

Loading

baralhao commented Oct 18, 2018

	data["latlng"] = list(map(float, data["latlng"]))
	data["latlng"] = [float(coord) for coord in data["latlng"]]

Adding Interactive Map with cases #14

Adding Interactive Map with cases #14

Conversation

ellisonleao commented Oct 10, 2018

cuducos commented Oct 11, 2018

ellisonleao commented Oct 11, 2018 • edited Loading

turicas commented Oct 11, 2018

ellisonleao commented Oct 12, 2018 • edited Loading

turicas commented Oct 12, 2018

ellisonleao commented Oct 12, 2018 • edited Loading

cuducos commented Oct 15, 2018

cuducos Oct 17, 2018

Choose a reason for hiding this comment

cuducos Oct 17, 2018

Choose a reason for hiding this comment

ellisonleao Oct 17, 2018 • edited Loading

Choose a reason for hiding this comment

ellisonleao commented Oct 18, 2018 • edited Loading

baralhao commented Oct 18, 2018

ellisonleao commented Oct 11, 2018 •

edited

Loading

ellisonleao commented Oct 12, 2018 •

edited

Loading

ellisonleao commented Oct 12, 2018 •

edited

Loading

ellisonleao Oct 17, 2018 •

edited

Loading

ellisonleao commented Oct 18, 2018 •

edited

Loading