Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make plugin_version optional when adding plugin data #13

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

faradox
Copy link
Contributor

@faradox faradox commented Nov 30, 2023

This PR introduces a small fix that makes the plugin_version argument optional when adding plugin data directly to a track or via the library. If the plugin_version is not specified, the library will determine it automatically via the plugin registry.

Copy link
Contributor

@aaronabebe aaronabebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faradox faradox merged commit d5c9b73 into main Nov 30, 2023
@faradox faradox deleted the fix/add-plugin-data-version-optional branch November 30, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants