Feat/objectarium pin unpin mapper #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErikssonJoakim I've refined the implementation style (a bit) to enhance its simplicity and clarity - see dd807f1. |
ccamel
force-pushed
the
feat/objectarium-pin-unpin-mapper
branch
from
dd807f1
to
f6a5d1e
Compare
ccamel
force-pushed
the
feat/objectarium-pin-unpin-mapper
branch
from
f6a5d1e
to
b660756
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of
It adds the pins field to keep track of who's pinned an object.
As a follow up we should add tests and I would suggest making the pins field in the schema obligatory with optional elements once this issue has been fixed.