fix: remove useless isDestructive prop

okta · Aug 16, 2023 · ea5e44c · ea5e44c
1 parent efe3af9
commit ea5e44c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/packages/odyssey-react-mui/src/MenuItem.tsx b/packages/odyssey-react-mui/src/MenuItem.tsx
@@ -32,10 +32,6 @@ export type MenuItemProps = {
    * If `true`, the menu item will be visually marked as selected.
    */
   isSelected?: boolean;
-  /**
-   * If `true`, the menu item will be visually marked as destructive.
-   */
-  isDestructive?: boolean;
   /**
    * If `true`, the menu item will be visually marked as disabled.
    */

diff --git a/packages/odyssey-storybook/src/components/odyssey-mui/MenuButton/MenuButton.stories.tsx b/packages/odyssey-storybook/src/components/odyssey-mui/MenuButton/MenuButton.stories.tsx
@@ -246,7 +246,7 @@ export const WithDestructive: StoryObj<MenuButtonProps> = {
     children: [
       <MenuItem key="1">View details</MenuItem>,
       <MenuItem key="2">Edit inventory</MenuItem>,
-      <MenuItem isDestructive key="3">
+      <MenuItem variant="destructive" key="3">
         Jettison cargo
       </MenuItem>,
     ],