DataView bugfixes #2347
Merged
DataView bugfixes #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlister-okta
previously approved these changes
Sep 11, 2024
|
Looks good to me code-wise, if you need a re-approval after changing the target branch let me know. |
bryancunningham-okta
previously approved these changes
Sep 11, 2024
|
Do we want to attempt to add tests to cover these fixes? Probably just the results per page one. Not sure we'd want to test styling |
jordankoschei-okta
dismissed stale reviews from bryancunningham-okta and benlister-okta
The base branch was changed.
|
This latest commit fixes the broken table virtualization. It also adds an automatic scroll-to-bottom when clicking the "Load More" button, because that interaction is super weird otherwise (you can load in new rows and never realize). |
bryancunningham-okta
previously approved these changes
Sep 18, 2024
| @@ -119,6 +119,7 @@ | |||
| "react": "^18.2.0", | |||
| "react-dom": "^18.2.0", | |||
| "regenerator-runtime": "^0.14.1", | |||
| "resize-observer-polyfill": "^1.5.1", | |||
There was a problem hiding this comment.
This package was last published 6 years ago, but many people are using it, and it's MIT licensed, so we should be fine.
I think this is kind of unnecessary, but once I get Playwright, we'll have it figured out.
bryancunningham-okta
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugfixes in response to @zhengchen-okta discoveries:
loadMore