Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKTA-584321 docs for pairwise #4050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mymoonasaifunnissameerasahib-okta
Copy link
Contributor

@mymoonasaifunnissameerasahib-okta mymoonasaifunnissameerasahib-okta commented Mar 22, 2023

Description:

  • What's changed? doc changes for pairwise identifier
  • Is this PR related to a Monolith release? Pairwise FF is not enabled yet

Resolves:

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score DRAFT 06.01.22

A minimum Acrolinx Score of 40 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, ex. Correctness. Your article will be clearer and more consistent with Microsoft standards.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 40
Correctness
(Spelling, grammar)
Preferred: 40
Clarity
(Readability)
Preferred: 10
Inclusive language
(+ accesibility)
Preferred: 10
packages/@okta/vuepress-site/docs/reference/api/apps/index.md 65 67 71 37 71
packages/@okta/vuepress-site/docs/reference/api/oauth-clients/index.md 69 84 63 39 67
packages/@okta/vuepress-site/docs/reference/api/oidc/index.md 68 79 66 29 89

Copy link
Contributor

@franklu-okta franklu-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide the screenshot? I think that will be easier for us to see what you have changed. Thank you.

@mymoonasaifunnissameerasahib-okta
Copy link
Contributor Author

image
image

image
image

image
image

@mymoonasaifunnissameerasahib-okta
Copy link
Contributor Author

Can you please provide the screenshot? I think that will be easier for us to see what you have changed. Thank you.

updated

Copy link
Contributor

@franklu-okta franklu-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@susanharper-okta susanharper-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score DRAFT 06.01.22

A minimum Acrolinx Score of 40 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, ex. Correctness. Your article will be clearer and more consistent with Microsoft standards.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 40
Correctness
(Spelling, grammar)
Preferred: 40
Clarity
(Readability)
Preferred: 10
Inclusive language
(+ accesibility)
Preferred: 10
packages/@okta/vuepress-site/docs/reference/api/apps/index.md 65 67 71 37 71
packages/@okta/vuepress-site/docs/reference/api/oauth-clients/index.md 69 84 64 39 67
packages/@okta/vuepress-site/docs/reference/api/oidc/index.md 68 79 66 29 89

Copy link
Contributor

@susanharper-okta susanharper-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple edits

Copy link
Contributor

@susanharper-okta susanharper-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianduffield-okta brianduffield-okta added the On Hold For features that were going to be released, but are now on hold label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Hold For features that were going to be released, but are now on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants