Skip to content

Commit

Permalink
Prevent the app from being suspended while refreshing a token (#193)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikenachbaur-okta authored May 17, 2024
1 parent 1a533d8 commit ff18754
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 2 deletions.
5 changes: 5 additions & 0 deletions Sources/AuthFoundation/OAuth2/OAuth2Client.swift
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,13 @@ public final class OAuth2Client {
refreshToken: refreshToken,
id: token.id,
configuration: clientSettings)
let backgroundTask = BackgroundTask(named: "Refresh Token \(token.id)")
request.send(to: self) { result in
self.refreshQueue.sync(flags: .barrier) {
defer {
backgroundTask.finish()
}

switch result {
case .success(let response):
let newToken = response.result.token(merging: token)
Expand Down
39 changes: 39 additions & 0 deletions Sources/AuthFoundation/Utilities/BackgroundTaskWrapper.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
//
// Copyright (c) 2024-Present, Okta, Inc. and/or its affiliates. All rights reserved.
// The Okta software accompanied by this notice is provided pursuant to the Apache License, Version 2.0 (the "License.")
//
// You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//
// See the License for the specific language governing permissions and limitations under the License.
//

import Foundation

#if os(iOS) || os(tvOS) || targetEnvironment(macCatalyst)
import UIKit

final class BackgroundTask {
let task: UIBackgroundTaskIdentifier

init(named name: String? = nil) {
task = UIApplication.shared.beginBackgroundTask(withName: name)
}

deinit {
finish()
}

func finish() {
UIApplication.shared.endBackgroundTask(task)
}
}
#else
final class BackgroundTask {
init(named name: String? = nil) {}

func finish() {}
}
#endif
2 changes: 0 additions & 2 deletions Tests/AuthFoundationTests/TokenTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ final class TokenTests: XCTestCase {


func testMFAAttestationTokenFailed() throws {
let request = MockTokenRequest(clientId: configuration.clientId,
url: configuration.baseURL)
let decoder = defaultJSONDecoder
decoder.userInfo = [
.apiClientConfiguration: configuration,
Expand Down

0 comments on commit ff18754

Please sign in to comment.