Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client id matching #166

Conversation

colintremblay-okta
Copy link
Contributor

Client IDs for 1st party apps (like Okta Personal's iOS app) have don't match the regex. Since we have access to the client ID, we can first do a check against that instead of the regex, then default the the current behavior if that doesn't work.

This PR:

  • covers the failing scenario with a unit test
  • fixes the failing scenario
  • also fixes a small documentation issue (removes a parameter from the docs that isn't in the actual function)

@mikenachbaur-okta mikenachbaur-okta changed the base branch from master to colintremblay-okta-cjt-fix-clientId-matching February 7, 2024 00:27
Copy link
Contributor

@mikenachbaur-okta mikenachbaur-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'll target a feature branch with this PR and will trigger a new PR from there to ensure the UI tests run.

@mikenachbaur-okta mikenachbaur-okta merged commit 5e47c3e into colintremblay-okta-cjt-fix-clientId-matching Feb 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants