Matthew john 1894 #1910
Open
Matthew john 1894 #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exactly matches. In the case where there are two apps: "MyApp" and "MyApp 2". If the data source for saml apps queried with label "MyApp", if the API returns "MyApp 2" as the first app in the list, the data source will fail. This change now iterate through all of the apps returned and returning an exact match, if "label" has been specified.
…iple-apps' into MatthewJohn_1894
monde
approved these changes
Feb 23, 2024
MatthewJohn
reviewed
Feb 28, 2024
| // property. We need to further inspect for an exact label match. | ||
| if filters.Label != "" { | ||
| // guard on nils, an app is always set | ||
| app = appList[0] |
There was a problem hiding this comment.
@duytiennguyen-okta I see you've modified to perform initial assignment, but this will assign it to the first app, even if it doesn't match and there's no logic to fail if a matching app isn't found in the for-loop
There was a problem hiding this comment.
Is it important that app is always set? Given that if it isn't, we were returning a diag error in 912cfb5#diff-bd713a1119c4af963b9c842b006fdbe0a563da383f7172d61e764375ce3831e6L326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1894