Feat: DataSource okta_apps #1967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exitcode0
force-pushed
the
datasource_okta_apps
branch
from
f245a8e
to
90af3bc
Compare
exitcode0
force-pushed
the
datasource_okta_apps
branch
from
e7c5d1b
to
e4fe032
Compare
exitcode0
changed the title
|
@duytiennguyen-okta any chance I could trouble you for a code review on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry picked an existing PR and had a crack at implementing this with the terraform provider framework
I'm still pretty clueless with GoLang and would love feedback so I can tweak this as needed
I had some trouble trying to get additional information to work with the dataSource, things like the appSettings, appVisibility, appCredentials - I couldn't figure out how to go about creating an interface for these types, i'd love some guidance on this if possible