Remove inactivity_period default value from app_signon_policy_rule #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It checks that `inactivity_period` is not set if not defined, which is the desired behavior.
duytiennguyen-okta
added
the
breaking-change
|
@reinoudk yes, it is a breaking change and will have to wait for v5 to be released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1573 which, even though closed as
stale, I think should be fixed.For example, when creating a rule through the UI or when not explicitly setting this value through the API, the JSON that is returned when subsequently pulling the rule from the API will also not have a value for
inactivityPeriod. The provider docs do not specify a default value either.Note: I realize this could considered be a breaking change w.r.t. how the provider handled this value up until now 😬.