Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document priorityClassName #511

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Document priorityClassName #511

merged 7 commits into from
Oct 19, 2023

Conversation

AgustinRamiroDiaz
Copy link
Contributor

@AgustinRamiroDiaz AgustinRamiroDiaz commented Oct 10, 2023 •
edited
Loading

Implemented in https://github.com/okteto/app/pull/7309
Some missing configurations I didn't add due to their sections not being present:

  • installerChecker
  • nodeReadinessChecker
  • migration
  • namespaceDestroyAll

Should I create their sections?

@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for okteto-docs ready!

Name Link
🔨 Latest commit bd86a27
🔍 Latest deploy log https://app.netlify.com/sites/okteto-docs/deploys/6527daf08c143800075e7cb2
😎 Deploy Preview https://deploy-preview-511--okteto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pchico83
pchico83 reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@pchico83 pchico83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeRedinessChecker is internal, but for other ones, I would create the sections, or file issues to document them. Especially, the migration job should be documented

src/content/self-hosted/administration/configuration.mdx Outdated Show resolved Hide resolved
@AgustinRamiroDiaz
Improve writing
40fc521 
Signed-off-by: Agustín Díaz <[email protected]>
@AgustinRamiroDiaz
Remove nodeReadinessChecker
bd86a27 
Signed-off-by: Agustín Díaz <[email protected]>
@AgustinRamiroDiaz AgustinRamiroDiaz mentioned this pull request Oct 12, 2023
Open
3 tasks
@AgustinRamiroDiaz
Copy link
Contributor Author

Deferred documentation of the sections to #513

@AgustinRamiroDiaz AgustinRamiroDiaz merged commit 71e4b66 into main Oct 19, 2023
4 checks passed
@AgustinRamiroDiaz AgustinRamiroDiaz deleted the agustin/docs-priority-class branch October 19, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchico83 pchico83 pchico83 approved these changes

@rberrelleza rberrelleza Awaiting requested review from rberrelleza

@omnomagonz omnomagonz Awaiting requested review from omnomagonz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgustinRamiroDiaz @pchico83