Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong efficiency calculation for RPS #27

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

palant
Copy link
Contributor

@palant palant commented May 9, 2022

This fixes #18. Clippy in fact complained about this.

@olafurw
Copy link
Owner

olafurw commented May 9, 2022

You got a clippy warning? Huh I remember committing because I didn't get any.

@olafurw olafurw merged commit 469c4ff into olafurw:main May 9, 2022
@palant
Copy link
Contributor Author

palant commented May 9, 2022

It’s still complaining about RPS which should be named Rps. 🤷

@palant palant deleted the fix-rps branch May 9, 2022 13:30
@olafurw
Copy link
Owner

olafurw commented May 9, 2022

I'm fine with that change, I just didn't name it RockPaperScissors because I felt it was long but we can rename it to that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out why Rock/Paper/Scissor doesn't move after first frame.
2 participants