Fixed small liteboard issue when loading in development mode #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avicon handlers - Return lowercase response headers and explicit content-type from Liteboard#after to satisfy Rack 3 Lint (Cache-Control → cache-control). - Add explicit /favicon.ico handler returning 204 No Content to avoid repeated browser requests and ensure a valid Rack triplet. - Add default 404 handler for unmatched routes so every request path returns a proper [status, headers, body] response. This resolves errors seen in development with Rack 3: - Rack::Lint::LintError: uppercase character in header name: Cache-Control - NoMethodError in Rack::TempfileReaper when an unmatched path returned nil. Repro: liteboard -d db/development.sqlite3 --env=development Visit "/" and "/favicon.ico" Issue: Loading liteboard in development gave the following error: `Rack::Lint::LintError: uppercase character in header name: Cache-Control (Rack::Lint::LintError)` Also, there was no handler for favicon.ico, so I added one. After: Both routes return valid responses; no Rack::Lint or TempfileReaper errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Liteboard Rack 3–compliant in development by fixing response headers and default handlers. Minor infra tweak aligned with our ongoing SQLite-first litestack work.
Changes
Testing