-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another bloody gnome shell api change that are only documented in git… #41
base: master
Are you sure you want to change the base?
Conversation
…hub complaints of extensions that no longer seem to work. Apparently slider.connect('value-changed' ... is now slider.connect('notify::value' !@$ss#
For example, "Usage of object.actor is deprecated for Indicator"
* can install to ~/.local/share/gnome-shell/extensions * added schema entry to locate gnome-shell-timer-config script * the xml is initialized with the actual DEST of the install depending on whether it is system or local
* repopulate the presets when the main menu is opened
* updates for 3.38
FWIW, I have created a fork of gnome-shell-timer where I merged your pull request and some other pending changes that I had in the Debian package. I won't spend much time on the extension but I will gladly review and merge contributions like yours in the future to keep it working with the latest GNOME releases. I can even grant you commit rights if you are interested. It's over here: https://github.com/rhertzog/gnome-shell-timer |
Thanks, but I decided to bite the bullet in December and rewrite the extension, https://github.com/blackjackshellac/kitchenTimer https://extensions.gnome.org/extension/3955/kitchen-timer/ Check it out, it can run multiple simultaneous timers and has tons of other features. |
Nice! I'm glad that I don't have to maintain my fork and that I can switch to your extension. I might even package it for Debian at some point, as a replacement for gnome-shell-timer. |
Great. I added support for 3.36 for an ubuntu 20.04 LTS user, but I doubt I'd be able t easily backup to anything prior to that. but I never did try 18 or 19. |
…hub complaints of extensions that no longer seem to work.
Apparently slider.connect('value-changed' ... is now slider.connect('notify::value'
!@$ss#