Javascript 3 #4
Open
Javascript 3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korzio
suggested changes
Nov 20, 2018
| var xmlHttp = new XMLHttpRequest(); | ||
| xmlHttp.open("GET", "http://127.0.0.1:3000", true); | ||
| xmlHttp.send(null); | ||
| http.get('http://127.0.0.1:3000'); | ||
| } |
| var xmlHttp = new XMLHttpRequest(); | ||
| xmlHttp.open("GET", "http://127.0.0.1:3000", true); | ||
| xmlHttp.send(null); | ||
| http.get('http://127.0.0.1:3000'); |
There was a problem hiding this comment.
В обоих случаях запросы отправятся параллельно
javascript/javascript-3_request.js
Outdated
| var xmlHttp = new XMLHttpRequest(); | ||
| xmlHttp.open("GET", "http://127.0.0.1:3000", true); | ||
| xmlHttp.send(null); | ||
| http.get('http://127.0.0.1:3000'); |
There was a problem hiding this comment.
Созданный Promise выполнит конструктор сразу, поэтому здесь происходят параллельные запросы. Если этот код для последовательных запросов, то не хватает логики для ожидания выполнения Promise
korzio
approved these changes
Nov 26, 2018
| if(res!== undefined) | ||
| { | ||
| N--; | ||
| while (N>0) return request(N,type); |
There was a problem hiding this comment.
Довольно странная конструкция - для чего нужен while?
| xmlHttp.open("GET", "http://127.0.0.1:3000", true); | ||
| xmlHttp.send(null); | ||
| }) | ||
| http.get('http://127.0.0.1:3000', (res) => { |
There was a problem hiding this comment.
Повторяющийся код и константа с параллельными запросами
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes according requests