Skip to content

Commit

Permalink
graphql-ws: optimise the "resolve" routine
Browse files Browse the repository at this point in the history
* Partially addresses cylc#547
* The resolve routine is implmented recursively in the graphql-ws
  library.
* Because the function is async this results in a large number of async
  tasks being created when the library is used with large, deeply nested
  schema.
* Async tasks have an overhead, above that of regular function calls.
* For the example in cylc#547
  this resulted in over 10 seconds of overheads.
  • Loading branch information
oliver-sanders committed Jan 10, 2024
1 parent 864d1b0 commit 6c6a2b4
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 1 deletion.
1 change: 1 addition & 0 deletions changes.d/548.feat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve the performance of the GraphQL server.
66 changes: 66 additions & 0 deletions cylc/uiserver/websockets/resolve.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
# MIT License
#
# Copyright (c) 2017, Syrus Akbary
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

"""
This file contains an implementation of "resolve" derived from the one
found in the graphql-ws library with the above license.
This is temporary code until the change makes its way upstream.
"""

# NOTE: transient dependency from graphql-ws not
from promise import Promise

from graphql_ws.base_async import is_awaitable


async def resolve(
data,
_container=None,
_key=None,
):
"""
Recursively wait on any awaitable children of a data element and resolve
any Promises.
"""
stack = [(data, _container, _key)]

while stack:
_data, _container, _key = stack.pop()

if is_awaitable(_data):
_data = await _data
if isinstance(_data, Promise):
_data = _data.value
if _container is not None:
_container[_key] = _data
if isinstance(_data, dict):
items = _data.items()
elif isinstance(_data, list):
items = enumerate(_data)
else:
items = None
if items is not None:
stack.extend([
(child, _data, key)
for key, child in items
])
4 changes: 3 additions & 1 deletion cylc/uiserver/websockets/tornado.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from graphql.execution.middleware import MiddlewareManager
from graphql_ws.base import ConnectionClosedException
from graphql_ws.base_async import (
resolve,
BaseAsyncConnectionContext,
BaseAsyncSubscriptionServer
)
Expand All @@ -29,6 +28,9 @@
from typing import Union, Awaitable, Any, List, Tuple, Dict, Optional

from cylc.uiserver.authorise import AuthorizationMiddleware
from cylc.uiserver.websockets.resolve import resolve


setup_observable_extension()

NO_MSG_DELAY = 1.0
Expand Down

0 comments on commit 6c6a2b4

Please sign in to comment.