Support exporting configured_hz from info server
#944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `dynamic-hz` configuration option is in-use (Redis 6+), Redis will include `configured_hz` in the output of `info server`. The `hz` that is currently configured can impact Redis CPU utilization. This introduces exporting the server's current `configured_hz` value.
Pull Request Test Coverage Report for Build 10813968541Details
💛 - Coveralls |
|
Looks good. |
oliver006
force-pushed
the
master
branch
2 times, most recently
from
ad70547
to
3526bf7
Compare
The unit in this case is actually just |
|
Updated to add |
|
PR looks good! Can you please rebase and pull in the new changes that run the tests in Github Actions? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #944 +/- ##
==========================================
+ Coverage 80.19% 80.25% +0.06%
==========================================
Files 17 17
Lines 1974 1980 +6
==========================================
+ Hits 1583 1589 +6
Misses 306 306
Partials 85 85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
dynamic-hzconfiguration option is in-use (Redis 6+), Redis will includeconfigured_hzin the output ofinfo server. Thehzthat is currently configured can impact Redis CPU utilization.This introduces exporting the server's current
configured_hzvalue.