Feature: Add redis search module metrics #953
Open
+227
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nantiferov
commented
Sep 10, 2024
| "commands_total": {txt: `Total number of calls per command`, lbls: []string{"cmd"}}, | ||
| "commands_latencies_usec": {txt: `A histogram of latencies per command`, lbls: []string{"cmd"}}, | ||
| "latency_percentiles_usec": {txt: `A summary of latency percentile distribution per command`, lbls: []string{"cmd"}}, | ||
| "config_client_output_buffer_limit_bytes": {txt: `The configured buffer limits per class`, lbls: []string{"class", "limit"}}, |
There was a problem hiding this comment.
I haven't changed this part, but looks like go fmt wasn't run in for config_client_output_buffer_limit_overcome_seconds in #933
I think it's worth to add linter check for formatting in CI.
nantiferov
force-pushed
the
Feature--Add-redis-search-module-metrics
branch
3 times, most recently
from
b6959b0
to
3f02f94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 80.19% 80.40% +0.21%
==========================================
Files 17 18 +1
Lines 1974 2021 +47
==========================================
+ Hits 1583 1625 +42
- Misses 306 310 +4
- Partials 85 86 +1 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10814531479Details
💛 - Coveralls |
nantiferov
force-pushed
the
Feature--Add-redis-search-module-metrics
branch
from
f75fe7b
to
fc94ed9
Compare
nantiferov
force-pushed
the
Feature--Add-redis-search-module-metrics
branch
from
402bacd
to
7c51e0c
Compare
2 tasks
nantiferov
force-pushed
the
Feature--Add-redis-search-module-metrics
branch
from
7c51e0c
to
081482b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #942
Found that redis returns all related information to modules with
info modulesand added collection of all metrics that looks useful so far.Parsing of
module:name=RedisCompat,ver=1,api=1,filters=0,usedby=[],using=[],options=[]is not ideal, but works fine with current Redis 7.4 / Redis search module 2.10