Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aof incr file size #978

Closed

Conversation

dudizimber
Copy link

@dudizimber dudizimber commented Feb 12, 2025

fix #977

Add a new opt-in metric to monitor AOF incr file sizes.

@dudizimber dudizimber closed this Feb 12, 2025
@dudizimber dudizimber reopened this Feb 12, 2025
@oliver006
Copy link
Owner

I think this is fundamentally broken as it assumes that the exporter has access to the appenddirname directory which is not necessarily true, putting it in the exporter doesn't seem right.
There are probably other ways for you to expose this metric (shell script and node exporter?).

@dudizimber
Copy link
Author

The permission issue is a valid point, so the metric requires the flag -include-aof-file-size to be set for the exporter to run.

Although it's possible to expose the metric with node_exporter, bundling it with the rest of Redis's metrics makes more sense. Moreover, exposing it through node_exporter is a cumbersome process and requires installation and scraping, which is not always guaranteed. redis_exporter is the standard tool for exporting Redis's metrics, so it's safer to assume that it will be used to handle Redis-related metrics.

@oliver006
Copy link
Owner

The exporter currently works exclusively via the network connection that the exporter opens to the valkey/redis instance, this change would break that paradigm.
As I pointed out above, you can add this independently from the exporter to e.g. the node_exporter that you might be running on your valkey/redis node and gather the data like that.

@oliver006 oliver006 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitor aof incr file size
2 participants