-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gitstatus.py] Use --porcelain to make faster in using python #65
base: master
Are you sure you want to change the base?
[gitstatus.py] Use --porcelain to make faster in using python #65
Conversation
8cb257a
to
0d5a3f5
Compare
c0e5025
to
f95d5b5
Compare
Hi @wkentaro, I'm using your modification in ohmyzsh/ohmyzsh#4205 because it is the best one here. $ git status --porcelain -b
## fix-git-prompt-plugin...origin/fix-git-prompt-plugin [ahead 2, behind 2] |
Ok, thanks. |
I sent PR: mcornella/ohmyzsh#2 |
c0ef3dc
to
7efd692
Compare
@olivierverdier I can confirm this works perfectly, and it only uses one call to |
I had to push a patch to make this work for UTF-8 locales, see mcornella/ohmyzsh@b289beb and ohmyzsh/ohmyzsh#4205 (comment). |
Thanks. I updated. |
There are some other caveats with the |
Thanks, I updated. |
425e7df
to
884a449
Compare
884a449
to
825f8ad
Compare
I think this PR should be merged after ohmyzsh/ohmyzsh#4205 is merged. After it is merged, I will update all same commits to this PR. |
ohmyzsh/ohmyzsh#4205 |
Based off of changes: olivierverdier/zsh-git-prompt#65
Based off of changes by @wkentaro to zsh-git-prompt see: olivierverdier/zsh-git-prompt#65
65cdd90
to
526fd76
Compare
@olivierverdier
it compares the speed with |
526fd76
to
ab7512a
Compare
ping |
Thanks for the update. I wrote some comments in the commit. Basically, I think that we need unit tests as well. |
Ok so you mean we should split the code in gitstatus.py and test each functions? |
Yes, exactly. (sorry for the late answer) |
Get files' status by parsing output of
git status --porcelain
to make it faster.