feat(server): default to using rustls-tls #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both kube and kubert allow the rustls-tls and openssl-tls features simultaneously. However, their default behaviors differ, which causes clients and servers to use different TLS implementations when both features are enabled: * kube clients use rustls-tls by default; * kubert servers use openssl-tls by default. This commit changes the default behavior of kubert servers to use rustls-tls when both features are enabled, aligning with [kube]. [kube]: https://github.com/kube-rs/kube/blob/6a980c6ea50f2f3f4f2867d3df3fd77be00fca84/kube-client/src/client/builder.rs#L157-L165
olix0r
force-pushed
the
ver/tls-preference
branch
from
9c4a492 to
936c66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both kube and kubert allow the rustls-tls and openssl-tls features simultaneously. However, their default behaviors differ, which causes clients and servers to use different TLS implementations when both features are enabled:
This commit changes the default behavior of kubert servers to use rustls-tls when both features are enabled, aligning with kube.