Feature/gcpps09 92 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dPlatform#1996) * test: add integration test for empty string csv * Fix typo and make CSV schema fields nullable Signed-off-by: Florent Biville <[email protected]> * chore: clean up unnecessary checks and tests * chore: fix style * test: add unit test for CsvSources * test: improvement on CsvSources test * chore: fix style * fix: add yaml support for specification parser * Revert "fix: add yaml support for specification parser" This reverts commit 03ff0ef9cc49de54d8e99b73c2c73c6a093e35c8. --------- Signed-off-by: Florent Biville <[email protected]>
…a (and other similar non-jdbc) values (GoogleCloudPlatform#1998)
* Enable HIDDEN for all column types * Added test for Avro -> Ddl and moved HIDDEN handling outside of generated loop
* docs: update template option descriptions ... so that it's also reflected on the README * fix: connection URI option wording Co-authored-by: Rebecca Szper <[email protected]> * fix: connection secret ID option wording Co-authored-by: Rebecca Szper <[email protected]> * fix: connection secret ID option wording Co-authored-by: Rebecca Szper <[email protected]> * fix: optionsJson wording Co-authored-by: Rebecca Szper <[email protected]> * fix: optionsJson wording Co-authored-by: Rebecca Szper <[email protected]> * fix: readQuery wording Co-authored-by: Rebecca Szper <[email protected]> * fix: inputFilePattern wording Co-authored-by: Rebecca Szper <[email protected]> * fix: inputFilePattern wording Co-authored-by: Rebecca Szper <[email protected]> * fix: reformat --------- Co-authored-by: Rebecca Szper <[email protected]>
* changes * changes * changes * change * change * change * change * change * changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.