Feat/googleps04 71 support set datatype #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| count := 0 | ||
| for i := 0; i < v.Len(); i++ { | ||
| listVal = append(listVal, v.Index(i).String()) | ||
| count++ |
| @@ -59,7 +59,7 @@ func RouteRequest(c *gin.Context) { | |||
| case "UpdateItem": | |||
| Update(c) | |||
| default: | |||
| c.JSON(errors.New("ValidationException", "Invalid X-Amz-Target header value of" + amzTarget). | |||
| c.JSON(errors.New("ValidationException", "Invalid X-Amz-Target header value of"+amzTarget). | |||
There was a problem hiding this comment.
Add a space after "of" before concatenating amzTarget
api/v1/condition.go
Outdated
| stringMap := make(map[string]struct{}) | ||
| for _, v := range a.SS { | ||
| if _, exists := stringMap[*v]; !exists { | ||
| stringMap[*v] = struct{}{} |
There was a problem hiding this comment.
So this change only handles deduplication.
storage/spanner.go
Outdated
| @@ -759,133 +758,157 @@ func parseRow(r *spanner.Row, colDDL map[string]string) (map[string]interface{}, | |||
| } | |||
| v, ok := colDDL[k] | |||
| if !ok { | |||
| fmt.Println(k) | |||
There was a problem hiding this comment.
Is this just left over debug logging?
| var m interface{} | ||
| if err := json.Unmarshal(s, &m); err != nil { | ||
| logger.LogError(err, string(s)) | ||
| row[col] = string(s) |
There was a problem hiding this comment.
Can you add a comment here as you are falling back to raw string.
| @@ -404,11 +404,7 @@ func TestChangeMaptoDynamoMap(t *testing.T) { | |||
| "age": map[string]interface{}{"N": "20"}, | |||
| "value": map[string]interface{}{"N": "10"}, | |||
| "array": map[string]interface{}{ | |||
| "L": []map[string]interface{}{ | |||
There was a problem hiding this comment.
So now we are mapping array to string set instead of list. This is a change in behavior and may break existing applications just like this test case.
taherkl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>