Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/googleps04 94 map datatype #9

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

shoaibcldcvr
Copy link
Collaborator

Fixes #GOOGLEPS04-94

This PR adds the datatype support for the Map.

  • Tests pass
  • [] Appropriate changes to README are included in PR

@shoaibcldcvr shoaibcldcvr marked this pull request as draft January 3, 2025 08:52
config-files/staging/config.json Outdated Show resolved Hide resolved
config-files/staging/spanner.json Outdated Show resolved Hide resolved
config-files/staging/tables.json Outdated Show resolved Hide resolved
service/services/services.go Outdated Show resolved Hide resolved
@taherkl
Copy link
Collaborator

taherkl commented Jan 6, 2025

Add documentation

@taherkl
Copy link
Collaborator

taherkl commented Jan 6, 2025

Add related UT and IT

storage/spanner.go Show resolved Hide resolved
storage/spanner.go Outdated Show resolved Hide resolved
@shoaibcldcvr
Copy link
Collaborator Author

Add related UT and IT

Integration Tests pending for UpdateItem, Scan and Query APIs.

@shoaibcldcvr shoaibcldcvr marked this pull request as ready for review January 10, 2025 11:08
api/v1/db.go Outdated Show resolved Hide resolved
},
},
},
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off and doesn't align with rest of the code. Here and below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is aligned to the other code. When viewed as file it looks in proper indented format.

service/services/services.go Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
32.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants