Skip to content

Commit

Permalink
addressed the comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Vivek Yadav committed Jan 9, 2025
1 parent 9508294 commit 6d048bd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-against-emulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
MYSQLUSER: root
MYSQLDATABASE: test_interleave_table_data
MYSQLDB_FKACTION: test_foreign_key_action_data
MYSQLDB_CHECKCONSTRAINTACTION: test_mysql_checkconstraint_actions
MYSQLDB_CHECK_CONSTRAINT: test_mysql_checkconstraint
MYSQLPWD: root

# set DynamoDB related environment variables
Expand Down
8 changes: 4 additions & 4 deletions test_data/mysql_checkconstraint_dump.test.out
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- MySQL dump 10.13 Distrib 8.3.0, for macos13.6 (arm64)
--
-- Host: 127.0.0.1 Database: test_mysql_checkconstraint_actions
-- Host: 127.0.0.1 Database: test_mysql_checkconstraint
-- ------------------------------------------------------
-- Server version 8.0.40

Expand All @@ -16,12 +16,12 @@
/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;

--
-- Current Database: `test_mysql_checkconstraint_actions`
-- Current Database: `test_mysql_checkconstraint`
--

CREATE DATABASE /*!32312 IF NOT EXISTS*/ `test_mysql_checkconstraint_actions` /*!40100 DEFAULT CHARACTER SET utf8mb4 */ /*!80016 DEFAULT ENCRYPTION='N' */;
CREATE DATABASE /*!32312 IF NOT EXISTS*/ `test_mysql_checkconstraint` /*!40100 DEFAULT CHARACTER SET utf8mb4 */ /*!80016 DEFAULT ENCRYPTION='N' */;

USE `test_mysql_checkconstraint_actions`;
USE `test_mysql_checkconstraint`;

--
-- Table structure for table `TestTable`
Expand Down
2 changes: 1 addition & 1 deletion testing/mysql/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ func TestIntegration_MYSQL_CheckConstraintsActionMigration(t *testing.T) {
dbURI := fmt.Sprintf("projects/%s/instances/%s/databases/%s", projectID, instanceID, dbName)
filePrefix := filepath.Join(tmpdir, dbName)

host, user, srcDb, password := os.Getenv("MYSQLHOST"), os.Getenv("MYSQLUSER"), os.Getenv("MYSQLDB_CHECKCONSTRAINTACTION"), os.Getenv("MYSQLPWD")
host, user, srcDb, password := os.Getenv("MYSQLHOST"), os.Getenv("MYSQLUSER"), os.Getenv("MYSQLDB_CHECK_CONSTRAINT"), os.Getenv("MYSQLPWD")
args := fmt.Sprintf("schema-and-data -source=%s -prefix=%s -source-profile='host=%s,user=%s,dbName=%s,password=%s' -target-profile='instance=%s,dbName=%s,project=%s'", constants.MYSQL, filePrefix, host, user, srcDb, password, instanceID, dbName, projectID)
err := common.RunCommand(args, projectID)
if err != nil {
Expand Down

0 comments on commit 6d048bd

Please sign in to comment.