comment addressed #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashthawaitcc
approved these changes
Jan 9, 2025
akashthawaitcc
merged commit 293bbf7
into
integration_test_checkconstraints
3 checks passed
VivekY1098
added a commit
that referenced
this pull request
Jan 16, 2025
* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * added the integration test 1. integration test added for check constraints. * updated the integration test * updated the insert query * removed unwanted code * fixed minor bug related to dump flow * resolve the IT issue * added missing cmd * fixed the mysql query * fixed the query added fixed * fixed the query (#45) * fixed the query * fixed * fixed the code * fixed query * updated the code * updated the code --------- Co-authored-by: Vivek Yadav <[email protected]> * comment addressed (#48) Co-authored-by: Vivek Yadav <[email protected]> * added fix (#49) Co-authored-by: Vivek Yadav <[email protected]> * fixed the issue without check constraints (#50) Co-authored-by: Vivek Yadav <[email protected]> * added the fix (#51) Co-authored-by: Vivek Yadav <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>