Fix PR tests for python >3.8 #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2023 14:27
There seems to be a bug with newer versions of pandas that prevents kwargs from being passed through the apply function (specifically passing errors='ignore' to to_numeric in edalize/vivado_reporting.py). Pinning pandas to v2.0.3 appears to have fixed the issue for now. I also added GOLDEN_RUN to pass through to tox.
Well, my previous attempt at a fix broke some other stuff. I pinned pandas to <= 2.0.3, since that version isn't available for python 3.7. I also changed a version check in edatool to prevent subprocess.run from being used for python 3.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug with newer versions of pandas that prevents kwargs from being passed through the apply function (specifically passing errors='ignore' to to_numeric in edalize/vivado_reporting.py). Pinning pandas to v2.0.3 appears to have fixed the issue for now.
I also added GOLDEN_RUN to pass through to tox.