Add vhdl compatibility to riviera pro #447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks fine and all. I'm a bit reluctant however to add more features to the backends that implement the old tool API rather than the new flow API. I will make an exception in this case, but I'm about to push Flow API support for QuestaSim, so for any further feature additions it would be great to use that as a base for a modernized rivierapro backend as well. |
|
A more severe issue is that it doesn't seem to pass CI tests, neither the formatting check or the actual tests. That needs to be fixed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to resolve the #446 issue.