Skip to content

Commit

Permalink
Fix duplicate notifications in Firefox. Fixes #189
Browse files Browse the repository at this point in the history
  • Loading branch information
olsh committed Jan 30, 2022
1 parent d906353 commit 682f678
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ Changelog can be found [here](https://github.com/olsh/Feedly-Notifier/releases).

1. `yarn`
2. `grunt sandbox --clientId=sandbox --clientSecret=R26NGS2Q9NAPSEJHCXM3 --browser=chrome`
You can find actual `clientId` and `clientSecret` [here](https://developer.feedly.com/cloud/)
You can find actual `clientId` and `clientSecret` [here](https://groups.google.com/g/feedly-cloud)
The browser parameter can be `chrome`, `opera` or `firefox`.
3. The result of the commands will be in `build` folder, now you can load the extension to browser.

## Acknowledgments

Made with
Made with

[![WebStorm](https://github.com/olsh/Feedly-Notifier/raw/master/logos/ws-logo.png)](https://www.jetbrains.com/webstorm/)
2 changes: 1 addition & 1 deletion src/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

"name": "Feedly Notifier",
"description": "__MSG_ExtensionDescription__",
"version": "2.26.1",
"version": "2.26.2",
"default_locale": "en",
"permissions": [
"storage",
Expand Down
9 changes: 0 additions & 9 deletions src/scripts/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ var appGlobal = {
};

// #Event handlers
// @if BROWSER!='firefox'
chrome.runtime.onInstalled.addListener(function (details) {
readOptions(function () {
//Write all options in chrome storage and initialize application
Expand All @@ -148,14 +147,6 @@ chrome.runtime.onInstalled.addListener(function (details) {
chrome.runtime.onStartup.addListener(function () {
readOptions(initialize);
});
// @endif

// @if BROWSER=='firefox'
readOptions(function () {
//Write all options in chrome storage and initialize application
writeOptions(initialize);
});
// @endif

chrome.storage.onChanged.addListener(function (changes, areaName) {
var callback;
Expand Down

0 comments on commit 682f678

Please sign in to comment.