Add ability to select sound notification (#239)

src/_locales/en/messages.json

@@ -176,6 +176,12 @@
   "Sorting": {
     "message": "Sorting"
   },
+  "Sound": {
+    "message": "Sound"
+  },
+  "SoundVolume": {
+    "message": "Sound volume"
+  },
   "Theme": {
     "message": "Theme"
   },

src/manifest.json

@@ -3,7 +3,7 @@
 
     "name": "Feedly Notifier",
     "description": "__MSG_ExtensionDescription__",
-    "version": "2.27.6",
+    "version": "2.28.0",
     "default_locale": "en",
     "permissions": [
         "storage",

src/options.html

@@ -116,7 +116,16 @@ <h3 data-locale-value="Notifications"></h3>
                 <input id="playSound" type="checkbox" data-option-name="playSound" /><br/>
 
                 <label for="soundVolume" class="label" data-locale-value="SoundVolume"></label>
-                <input id="soundVolume" type="range" data-enable-parent="playSound" min="0" max="1" step="0.01" data-option-name="soundVolume" /><br>
+                <input id="soundVolume" type="range" data-enable-parent="playSound" min="0.01" max="1" step="0.01" data-option-name="soundVolume" /><br>
+
+                <label for="sound" class="label" data-locale-value="Sound"></label>
+                <select id="sound" data-enable-parent="playSound" data-option-name="sound">
+                    <option value="sound/alert.mp3">Alert</option>
+                    <option value="sound/no-problem.mp3">No problem</option>
+                    <option value="sound/whistling.mp3">Whistling</option>
+                    <option value="sound/quite-impressed.mp3">Quite impressed</option>
+                    <option value="sound/light-hearted.mp3">Light hearted</option>
+                </select><br>
                 <!-- @endif -->
 
                 <div id="filters-settings">

src/scripts/core.js

@@ -38,6 +38,7 @@ var appGlobal = {
         filters: [],
         showCounter: true,
         playSound: true,
+        sound: "sound/alert.mp3",
         soundVolume: 0.8,
         sortBy: "newest",
         theme: "light",
@@ -386,7 +387,7 @@ function removeFeedFromCache(feedId) {
 
 /* Plays alert sound */
 function playSound(){
-    var audio = new Audio("sound/alert.mp3");
+    var audio = new Audio(appGlobal.options.sound);
     audio.volume = appGlobal.options.soundVolume;
     audio.play();
 }

src/scripts/options.js

@@ -35,7 +35,7 @@ $("body").on("click", "#logout", function () {
     $("#userInfo, #filters-settings").hide();
 });
 
-$("#options").on("change", "input", function (e) {
+$("#options").on("change", "input, select", function (e) {
     $("[data-enable-parent]").each(function(key, value){
         var child = $(value);
         var parent = $("input[data-option-name='" + child.data("enable-parent") + "']");
@@ -48,11 +48,20 @@ $("#options").on("change", "input", function (e) {
         parent.is(":checked") ? child.attr("disabled", "disable") : child.removeAttr("disabled");
     });
 
-    if (e.target.id === "soundVolume") {
-        if (optionsGlobal.loaded) {
+    if (e.target.id === "soundVolume" || e.target.id === "sound") {
+        if (!optionsGlobal.loaded) {
+            return;
+        }
+
+        if (e.target.id === "soundVolume") {
             chrome.extension.getBackgroundPage().appGlobal.options.soundVolume = e.target.value;
-            chrome.extension.getBackgroundPage().playSound();
         }
+
+        if (e.target.id === "sound") {
+            chrome.extension.getBackgroundPage().appGlobal.options.sound = e.target.value;
+        }
+
+        chrome.extension.getBackgroundPage().playSound();
     }
 });