Upgrade R# SDK to 2021.2.0 (#33)

* Upgrade R# SDK to 2021.2.0 * Gradle product version
olsh · Aug 19, 2021 · 16499f5 · 16499f5
1 parent cca5169
commit 16499f5
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 9 deletions.
diff --git a/.nuke/build.schema.json b/.nuke/build.schema.json
@@ -28,10 +28,13 @@
             "GitHubActions",
             "GitLab",
             "Jenkins",
+            "Rider",
             "SpaceAutomation",
             "TeamCity",
             "Terminal",
-            "TravisCI"
+            "TravisCI",
+            "VisualStudio",
+            "VSCode"
           ]
         },
         "IsRiderHost": {
@@ -41,6 +44,10 @@
           "type": "boolean",
           "description": "Disables displaying the NUKE logo"
         },
+        "Partition": {
+          "type": "string",
+          "description": "Partition to use on CI"
+        },
         "Plan": {
           "type": "boolean",
           "description": "Shows the execution plan (HTML)"

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,6 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
-    <SdkVersion>2021.1.1</SdkVersion>
+    <SdkVersion>2021.2.0</SdkVersion>
+  </PropertyGroup>
+  <!-- https://jetbrains.slack.com/archives/CBZ36NH7C/p1628090127002200 -->
+  <PropertyGroup>
+    <MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);MSB3277</MSBuildWarningsAsMessages>
   </PropertyGroup>
 </Project>
diff --git a/build/Build.cs b/build/Build.cs
@@ -116,7 +116,11 @@ protected override void OnBuildInitialized()
         .Requires(() => IsRiderHost)
         .Executes(() =>
         {
-            Gradle($"buildPlugin -PPluginVersion={ExtensionVersion} -PProductVersion={SdkVersion} -PDotNetOutputDirectory={OutputDirectory} -PDotNetProjectName={Project.Name}", customLogger:
+            // JetBrains is not very consistent in versioning
+            // https://github.com/olsh/resharper-structured-logging/issues/35#issuecomment-892764206
+            var productVersion = SdkVersion == "2021.2.0" ? "2021.2" : SdkVersion;
+
+            Gradle($"buildPlugin -PPluginVersion={ExtensionVersion} -PProductVersion={productVersion} -PDotNetOutputDirectory={OutputDirectory} -PDotNetProjectName={Project.Name}", customLogger:
                 (_, s) =>
                 {
                     // Gradle writes warnings to stderr

diff --git a/build/_build.csproj b/build/_build.csproj
@@ -7,6 +7,7 @@
     <NoWarn>CS0649;CS0169</NoWarn>
     <NukeRootDirectory>..</NukeRootDirectory>
     <NukeScriptDirectory>..</NukeScriptDirectory>
+    <NukeTelemetryVersion>1</NukeTelemetryVersion>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Resharper.ConfigurationSense/Resharper.ConfigurationSense.Rider.csproj b/src/Resharper.ConfigurationSense/Resharper.ConfigurationSense.Rider.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net461</TargetFramework>
-    <VersionPrefix>2021.1.0</VersionPrefix>
+    <TargetFramework>net472</TargetFramework>
+    <VersionPrefix>2021.2.0</VersionPrefix>
     <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
   </PropertyGroup>
   <PropertyGroup>
@@ -11,6 +11,6 @@
     <RootNamespace>Resharper.ConfigurationSense</RootNamespace>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="JetBrains.Rider.SDK" Version="$(SdkVersion)" />
+    <PackageReference Include="JetBrains.Rider.SDK" Version="$(SdkVersion)" PrivateAssets="all" />
   </ItemGroup>
 </Project>
diff --git a/src/Resharper.ConfigurationSense/Resharper.ConfigurationSense.csproj b/src/Resharper.ConfigurationSense/Resharper.ConfigurationSense.csproj
@@ -1,13 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net461</TargetFramework>
-    <VersionPrefix>2021.1.0</VersionPrefix>
+    <TargetFramework>net472</TargetFramework>
+    <VersionPrefix>2021.2.0</VersionPrefix>
     <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
   </PropertyGroup>
   <PropertyGroup>
     <SonarQubeTestProject>false</SonarQubeTestProject>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="JetBrains.ReSharper.SDK" Version="$(SdkVersion)" />
+    <PackageReference Include="JetBrains.ReSharper.SDK" Version="$(SdkVersion)" PrivateAssets="all" />
   </ItemGroup>
 </Project>