Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to build Android port #22

Closed
wants to merge 1 commit into from
Closed

Fix to build Android port #22

wants to merge 1 commit into from

Conversation

fnwinter
Copy link

ndk has no pthread_getname_np symbol yet, so it needs to be protected by ANDROID.
Also std::atomic_fetch_or / and are not provived by ndk. so change them to member functions.

@fnwinter
Copy link
Author

I didn't test this patch for linux yet.

@rpavlik
Copy link
Contributor

rpavlik commented Jan 24, 2022

atomic_fetch_or are actually available, they just needed manual qualification, see #17

The pthread symbol is in platform 26 and above - the cmake build system in #26 handles that.

@fnwinter
Copy link
Author

@rpavlik thank you for comments. this patch is not necessary anymore so I'll close this.

@fnwinter fnwinter closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants