avniproject#762 | Added FieldAttributes Enum , used it in MQB , Renam…

…ed createQuestionForIndividualTable method , Deleted MetabaseJoin

avni-server-api/src/main/java/org/avni/server/dao/metabase/DatabaseRepository.java

@@ -88,7 +88,7 @@ public void createQuestionForTable(Database database, TableDetails tableDetails,
         postForObject(metabaseApiUrl + "/card", requestBody.toJson(objectMapper), JsonNode.class);
     }
 
-    public void createQuestionForIndividualTable(Database database, TableDetails tableDetails) {
+    public void createQuestionForASingleTable(Database database, TableDetails tableDetails) {
         MetabaseQuery query = new MetabaseQueryBuilder(database, objectMapper.createArrayNode(), objectMapper)
                 .forTable(tableDetails)
                 .build();

avni-server-api/src/main/java/org/avni/server/domain/metabase/CardType.java

@@ -1,5 +1,6 @@
 package org.avni.server.domain.metabase;
 
+//Refer Documentation : https://www.metabase.com/docs/latest/api/card#post-apicard
 public enum CardType {
     QUESTION("question");
 

avni-server-api/src/main/java/org/avni/server/domain/metabase/FieldAttribute.java

@@ -0,0 +1,31 @@
+package org.avni.server.domain.metabase;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+
+public enum FieldAttribute {
+    FIELD("field"),
+    FIELDS("fields"),
+    SOURCE_TABLE("source-table"),
+    ALIAS("alias"),
+    CONDITION("condition"),
+    JOINS("joins"),
+    JOIN_ALIAS("join-alias"),
+    BASE_TYPE("base-type");
+
+    private final String attributeName;
+
+    FieldAttribute(String attributeName) {
+        this.attributeName = attributeName;
+    }
+
+    public String getAttributeName() {
+        return attributeName;
+    }
+
+    public ObjectNode toJson(ObjectMapper objectMapper, Object value) {
+        ObjectNode attributeNode = objectMapper.createObjectNode();
+        attributeNode.put(attributeName, value.toString());
+        return attributeNode;
+    }
+}

avni-server-api/src/main/java/org/avni/server/domain/metabase/BaseType.java → avni-server-api/src/main/java/org/avni/server/domain/metabase/FieldType.java

@@ -1,13 +1,15 @@
 package org.avni.server.domain.metabase;
 
-public enum BaseType {
+// Refer Documentation here : https://www.metabase.com/docs/latest/data-modeling/field-types
+
+public enum FieldType {
     INTEGER("type/Integer"),
     TEXT("type/Text"),
     BOOLEAN("type/Boolean");
 
     private final String typeName;
 
-    BaseType(String typeName) {
+    FieldType(String typeName) {
         this.typeName = typeName;
     }
 

avni-server-api/src/main/java/org/avni/server/domain/metabase/MetabaseQueryBuilder.java

@@ -18,34 +18,34 @@ public MetabaseQueryBuilder(Database database, ArrayNode joinsArray, ObjectMappe
     }
 
     public MetabaseQueryBuilder forTable(TableDetails tableDetails) {
-        queryNode.put("source-table", tableDetails.getId());
+        queryNode.put(FieldAttribute.SOURCE_TABLE.getAttributeName(), tableDetails.getId());
         return this;
     }
 
     public MetabaseQueryBuilder joinWith(TableDetails addressTable, FieldDetails joinField1, FieldDetails joinField2) {
         ObjectNode joinNode = objectMapper.createObjectNode();
-        joinNode.put("fields", "all");
-        joinNode.put("alias", addressTable.getName());
-        joinNode.put("source-table", addressTable.getId());
+        joinNode.put(FieldAttribute.FIELDS.getAttributeName(), "all");
+        joinNode.put(FieldAttribute.ALIAS.getAttributeName(), addressTable.getName());
 
         ArrayNode conditionArray = objectMapper.createArrayNode();
-        conditionArray.add("=");
+        conditionArray.add(ConditionType.EQUAL.getOperator());
 
         ArrayNode leftField = objectMapper.createArrayNode();
-        leftField.add("field");
+        leftField.add(FieldAttribute.FIELD.getAttributeName());
         leftField.add(joinField2.getId());
-        leftField.add(objectMapper.createObjectNode().put("base-type", "type/Integer"));
+        leftField.add(objectMapper.createObjectNode().put(FieldAttribute.BASE_TYPE.getAttributeName(), FieldType.INTEGER.getTypeName()));
         conditionArray.add(leftField);
 
         ArrayNode rightField = objectMapper.createArrayNode();
-        rightField.add("field");
+        rightField.add(FieldAttribute.FIELD.getAttributeName());
         rightField.add(joinField1.getId());
-        rightField.add(objectMapper.createObjectNode().put("base-type", "type/Integer").put("join-alias", addressTable.getName()));
+        rightField.add(objectMapper.createObjectNode().put(FieldAttribute.BASE_TYPE.getAttributeName(), FieldType.INTEGER.getTypeName()).put(FieldAttribute.JOIN_ALIAS.getAttributeName(), addressTable.getName()));
         conditionArray.add(rightField);
 
-        joinNode.set("condition", conditionArray);
+        joinNode.set(FieldAttribute.CONDITION.getAttributeName(), conditionArray);
+        joinNode.put(FieldAttribute.SOURCE_TABLE.getAttributeName(), addressTable.getId());
         joinsArray.add(joinNode);
-        queryNode.set("joins", joinsArray);
+        queryNode.set(FieldAttribute.JOINS.getAttributeName(), joinsArray);
 
         return this;
     }

avni-server-api/src/main/java/org/avni/server/domain/metabase/MetabaseRequestBody.java

@@ -4,6 +4,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 
+// Refer docs : https://www.metabase.com/docs/latest/api/card#post-apicard
 public class MetabaseRequestBody {
     private String name;
     private MetabaseQuery datasetQuery;

avni-server-api/src/main/java/org/avni/server/domain/metabase/VisualizationType.java

@@ -1,5 +1,6 @@
 package org.avni.server.domain.metabase;
 
+//Refer documentation : https://www.metabase.com/docs/latest/questions/sharing/visualizing-results
 public enum VisualizationType {
     TABLE("table"),
     CHART("chart");

avni-server-api/src/main/java/org/avni/server/service/metabase/AddressQuestionCreationService.java

@@ -32,6 +32,6 @@ public void createQuestionForTable(String tableName, String schema) {
         tableDetails.setName(tableName);
         TableDetails fetchedTableDetails = databaseRepository.findTableDetailsByName(database, tableDetails);
 
-        databaseRepository.createQuestionForIndividualTable(database, fetchedTableDetails);
+        databaseRepository.createQuestionForASingleTable(database, fetchedTableDetails);
     }
 }