Switch from new() to Pointer

bonsai/bonsai_impl_test.go

@@ -0,0 +1,5 @@
+package bonsai
+
+func Pointer[T any](d T) *T {
+	return &d
+}

bonsai/bonsai_test.go

@@ -8,10 +8,6 @@ import (
 	"path/filepath"
 )
 
-func Pointer[T any](d T) *T {
-	return &d
-}
-
 func init() {
 	initLogger()
 }

bonsai/plan_impl_test.go

@@ -39,8 +39,8 @@ func (s *ClientImplTestSuite) TestPlanAllResponseJsonUnmarshal() {
 				Name:                    "Sandbox",
 				PriceInCents:            0,
 				BillingIntervalInMonths: 1,
-				SingleTenant:            new(bool),
-				PrivateNetwork:          new(bool),
+				SingleTenant:            Pointer(false),
+				PrivateNetwork:          Pointer(false),
 				AvailableReleases: []string{
 					"elasticsearch-7.2.0",
 				},

bonsai/plan_test.go

@@ -68,8 +68,8 @@ func (s *ClientMockTestSuite) TestPlanClient_All() {
 			Name:                    "Sandbox",
 			PriceInCents:            0,
 			BillingIntervalInMonths: 1,
-			SingleTenant:            new(bool),
-			PrivateNetwork:          new(bool),
+			SingleTenant:            bonsai.Pointer(false),
+			PrivateNetwork:          bonsai.Pointer(false),
 			AvailableReleases: []bonsai.Release{
 				// TODO: we'll see whether the response is actually a
 				// shortened version like this or a slug
@@ -92,8 +92,8 @@ func (s *ClientMockTestSuite) TestPlanClient_All() {
 			Name:                    "Standard Small",
 			PriceInCents:            5000,
 			BillingIntervalInMonths: 1,
-			SingleTenant:            Pointer(false),
-			PrivateNetwork:          Pointer(false),
+			SingleTenant:            bonsai.Pointer(false),
+			PrivateNetwork:          bonsai.Pointer(false),
 			AvailableReleases: []bonsai.Release{
 				{Slug: "elasticsearch-5.6.16"},
 				{Slug: "elasticsearch-6.8.3"},
@@ -155,8 +155,8 @@ func (s *ClientMockTestSuite) TestPlanClient_GetByPath() {
 		Name:                    "Sandbox",
 		PriceInCents:            0,
 		BillingIntervalInMonths: 1,
-		SingleTenant:            new(bool),
-		PrivateNetwork:          new(bool),
+		SingleTenant:            bonsai.Pointer(false),
+		PrivateNetwork:          bonsai.Pointer(false),
 		AvailableReleases: []bonsai.Release{
 			{Slug: "elasticsearch-7.2.0"},
 		},

bonsai/release_test.go

@@ -54,21 +54,21 @@ func (s *ClientMockTestSuite) TestReleaseClient_All() {
 			Slug:        "elasticsearch-5.6.16",
 			ServiceType: "elasticsearch",
 			Version:     "5.6.16",
-			MultiTenant: Pointer(true),
+			MultiTenant: bonsai.Pointer(true),
 		},
 		{
 			Name:        "Elasticsearch 6.5.4",
 			Slug:        "elasticsearch-6.5.4",
 			ServiceType: "elasticsearch",
 			Version:     "6.5.4",
-			MultiTenant: Pointer(true),
+			MultiTenant: bonsai.Pointer(true),
 		},
 		{
 			Name:        "Elasticsearch 7.2.0",
 			Slug:        "elasticsearch-7.2.0",
 			ServiceType: "elasticsearch",
 			Version:     "7.2.0",
-			MultiTenant: Pointer(true),
+			MultiTenant: bonsai.Pointer(true),
 		},
 	}
 	releases, err := s.client.Release.All(context.Background())
@@ -108,7 +108,7 @@ func (s *ClientMockTestSuite) TestReleaseClient_GetBySlug() {
 		Name:        "Elasticsearch 7.2.0",
 		ServiceType: "elasticsearch",
 		Version:     "7.2.0",
-		MultiTenant: Pointer(true),
+		MultiTenant: bonsai.Pointer(true),
 	}
 
 	resultResp, err := s.client.Release.GetBySlug(context.Background(), targetReleaseSlug)

bonsai/space_test.go

@@ -92,7 +92,7 @@ func (s *ClientMockTestSuite) TestSpaceClient_GetByPath() {
 	s.NoError(err, "successfully get space by path")
 
 	s.Equal(targetSpacePath, space.Path)
-	s.Equal(new(bool), space.PrivateNetwork)
+	s.Equal(bonsai.Pointer(false), space.PrivateNetwork)
 	s.Equal("aws", space.Cloud.Provider)
 	s.Equal("aws-us-east-1", space.Cloud.Region)
 }