Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce S3FileSystemStore #82

Merged
merged 25 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fe114ac
Reintroduce S3FileSystemStore
dgault Mar 10, 2024
35a2fef
Add new openPlane function to read pixel data without initializing
dgault Mar 11, 2024
fcec4c8
Bump awssdk version
dgault Mar 13, 2024
07b60e2
Remove extra debug output
dgault Mar 14, 2024
f0683dc
Update dependencies
dgault Mar 15, 2024
5c4cc8b
S3FileStore: Use V1 AWS SDK to match microservices
dgault Apr 3, 2024
aa22866
Add commons-logging to excisions for AWS SDK
dgault Apr 3, 2024
ce1eed0
Declare commons-logging dependency at top level
dgault Apr 3, 2024
d9c0bb6
Add httpcore to JZarr exculsions
dgault Apr 3, 2024
141f8be
AWS client: Don't set region when endpoint configured
dgault Apr 4, 2024
44d5622
Only use S3FileSystemStore for https endpoint
dgault Apr 26, 2024
6944b02
Update src/loci/formats/S3FileSystemStore.java
dgault May 1, 2024
f28dab4
Correct spelling
dgault May 1, 2024
b1583c4
Removed redundant parameter
dgault May 1, 2024
c0a8352
Remove unused openPlane and openZarr
dgault May 1, 2024
50ffec1
Update ZrrReaderMock
dgault May 1, 2024
45736c7
JZarrServiceImpl: Correct protocol check
dgault May 10, 2024
ba5b955
S3FileSystemStore: Log stack trace rather than printing
dgault May 14, 2024
7ab9c35
Remove unused method
dgault May 14, 2024
93ee98d
JZarrServiceImpl: Refactor fetching of ZarrArray and ZarrGroup
dgault May 14, 2024
2bfe3db
JZarrServiceImple: Add new usingS3FileSystemStore method
dgault May 14, 2024
a54a40e
S3FileSystemStore: Add comments for path splitting
dgault May 14, 2024
51399b7
S3FileSystemStore: Removed unused getFiles method
dgault May 14, 2024
9a9bd34
S3FileSystemStore: Cleanup unused imports
dgault May 14, 2024
ea4ce08
JZarrServiceImpl: Remove unused code
dgault May 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,24 @@
<groupId>dev.zarr</groupId>
<artifactId>jzarr</artifactId>
<version>0.4.2</version>
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
Expand Down Expand Up @@ -91,9 +109,22 @@
<version>2.7.2</version>
<scope>runtime</scope>
</dependency>



<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-s3</artifactId>
<version>1.12.659</version>
<exclusions>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.2</version>
</dependency>
</dependencies>

<properties>
Expand Down
245 changes: 245 additions & 0 deletions src/loci/formats/S3FileSystemStore.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,245 @@
package loci.formats;

/*-
* #%L
* Implementation of Bio-Formats readers for the next-generation file formats
* %%
* Copyright (C) 2020 - 2022 Open Microscopy Environment
* %%
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
* #L%
*/

import com.bc.zarr.ZarrConstants;
import com.bc.zarr.ZarrUtils;
import com.bc.zarr.storage.Store;

import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.nio.file.FileSystem;
import java.nio.file.Files;
import java.nio.file.LinkOption;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
import java.util.ListIterator;
import java.util.TreeSet;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.amazonaws.services.s3.AmazonS3;
import com.amazonaws.services.s3.AmazonS3ClientBuilder;
import com.amazonaws.services.s3.model.ListObjectsRequest;
import com.amazonaws.services.s3.model.ObjectListing;
import com.amazonaws.services.s3.model.S3Object;
import com.amazonaws.services.s3.model.S3ObjectInputStream;
import com.amazonaws.services.s3.model.S3ObjectSummary;
import com.amazonaws.auth.AWSStaticCredentialsProvider;
import com.amazonaws.auth.AnonymousAWSCredentials;
import com.amazonaws.client.builder.AwsClientBuilder;

public class S3FileSystemStore implements Store {

private Path root;
AmazonS3 client;
public static final String ENDPOINT_PROTOCOL= "https://";
protected static final Logger LOGGER =
LoggerFactory.getLogger(S3FileSystemStore.class);

public S3FileSystemStore(String path, FileSystem fileSystem) {
if (fileSystem == null) {
root = Paths.get(path);
} else {
root = fileSystem.getPath(path);
}
setupClient();
}

public void updateRoot(String path) {
root = Paths.get(path);
}

public String getRoot() {
return root.toString();
}

private void setupClient() {
String[] pathSplit = root.toString().split(File.separator);
String endpoint = ENDPOINT_PROTOCOL + pathSplit[1] + File.separator;
try {
client = AmazonS3ClientBuilder.standard()
.withEndpointConfiguration(new AwsClientBuilder.EndpointConfiguration(endpoint, "auto"))
.withPathStyleAccessEnabled(true)
.withCredentials(new AWSStaticCredentialsProvider(new AnonymousAWSCredentials())).build();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably something worth documenting in the readme limitations i.e. the S3 functionality will exclusively work unauthenticated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is certainly a very limited solution that is tailored for the IDR use case, i would not particularly recommend this workflow to standard users, so the limitations would need to be clearly documented.

} catch (Exception e) {
LOGGER.info("Exception caught while constructing S3 client", e);
}

}

public void close() {
if (client != null) {
client.shutdown();
}
}

public S3FileSystemStore(Path rootPath) {
root = rootPath;
setupClient();
sbesson marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
public InputStream getInputStream(String key) throws IOException {
// Get the base bucket name from splitting the root path and removing the prefixed protocol and end-point
String[] pathSplit = root.toString().split(File.separator);
String bucketName = pathSplit[2];

// Append the desired key onto the remaining prefix
String key2 = root.toString().substring(root.toString().indexOf(pathSplit[3]), root.toString().length()) + File.separator + key;
melissalinkert marked this conversation as resolved.
Show resolved Hide resolved

try {
S3Object o = client.getObject(bucketName, key2);
S3ObjectInputStream responseStream = o.getObjectContent();
return responseStream;
} catch (Exception e) {
LOGGER.info( "Unable to locate or access key: " + key2, e);
}

return null;
}

@Override
public OutputStream getOutputStream(String key) throws IOException {
final Path filePath = root.resolve(key);
final Path dir = filePath.getParent();
Files.createDirectories(dir);
return Files.newOutputStream(filePath);
}

@Override
public void delete(String key) throws IOException {
final Path toBeDeleted = root.resolve(key);
if (Files.isDirectory(toBeDeleted)) {
ZarrUtils.deleteDirectoryTreeRecursively(toBeDeleted);
}
if (Files.exists(toBeDeleted)){
Files.delete(toBeDeleted);
}
if (Files.exists(toBeDeleted)|| Files.isDirectory(toBeDeleted)) {
throw new IOException("Unable to initialize " + toBeDeleted.toAbsolutePath().toString());
}
}

@Override
public TreeSet<String> getArrayKeys() throws IOException {
return getKeysFor(ZarrConstants.FILENAME_DOT_ZARRAY);
}

@Override
public TreeSet<String> getGroupKeys() throws IOException {
return getKeysFor(ZarrConstants.FILENAME_DOT_ZGROUP);
}

/**
* Copied from {@com.bc.zarr.storage.FileSystemStorage#getKeysEndingWith(String).
*
* @param suffix
* @return
* @throws IOException
*/
public TreeSet<String> getKeysEndingWith(String suffix) throws IOException {
return (TreeSet<String>)Files.walk(this.root).filter((path) -> {
return path.toString().endsWith(suffix);
}).map((path) -> {
return this.root.relativize(path).toString();
}).collect(Collectors.toCollection(TreeSet::new));
}

/**
* Copied from {@com.bc.zarr.storage.FileSystemStorage#getRelativeLeafKeys(String).
*
* @param key
* @return
* @throws IOException
*/
public Stream<String> getRelativeLeafKeys(String key) throws IOException {
Path walkingRoot = this.root.resolve(key);
return Files.walk(walkingRoot).filter((path) -> {
return !Files.isDirectory(path, new LinkOption[0]);
}).map((path) -> {
return walkingRoot.relativize(path).toString();
}).map(ZarrUtils::normalizeStoragePath).filter((s) -> {
return s.trim().length() > 0;
});
}

private TreeSet<String> getKeysFor(String suffix) throws IOException {
TreeSet<String> keys = new TreeSet<String>();

// Get the base bucket name from splitting the root path and removing the prefixed protocol and end-point
String[] pathSplit = root.toString().split(File.separator);
String bucketName = pathSplit[2];

// Append the desired key onto the remaining prefix
String key2 = root.toString().substring(root.toString().indexOf(pathSplit[3]), root.toString().length());

ListObjectsRequest listObjectsRequest = new ListObjectsRequest()
.withBucketName(bucketName)
.withPrefix(key2)
;

ObjectListing listObjectsResponse = null;
String lastKey = null;

do {
if ( listObjectsResponse != null ) {
listObjectsRequest = listObjectsRequest
.withMarker(lastKey)
;
}

listObjectsResponse = client.listObjects(listObjectsRequest);
List<S3ObjectSummary> objects = listObjectsResponse.getObjectSummaries();

// Iterate over results
ListIterator<S3ObjectSummary> iterVals = objects.listIterator();
while (iterVals.hasNext()) {
S3ObjectSummary object = (S3ObjectSummary) iterVals.next();
String k = object.getKey();
if (k.contains(suffix)) {
String key = k.substring(k.indexOf(key2) + key2.length() + 1, k.indexOf(suffix));
if (!key.isEmpty()) {
keys.add(key.substring(0, key.length()-1));
}
}
lastKey = k;
}
} while ( listObjectsResponse.isTruncated() );

return keys;
}
}
26 changes: 21 additions & 5 deletions src/loci/formats/in/ZarrReader.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ public class ZarrReader extends FormatReader {
public static final String LIST_PIXELS_ENV_KEY = "OME_ZARR_LIST_PIXELS";
public static final String INCLUDE_LABELS_KEY = "omezarr.include_labels";
public static final boolean INCLUDE_LABELS_DEFAULT = false;
public static final String ALT_STORE_KEY = "omezarr.alt_store";
public static final String ALT_STORE_DEFAULT = null;
protected transient ZarrService zarrService;
private ArrayList<String> arrayPaths = new ArrayList<String>();

Expand Down Expand Up @@ -189,7 +191,7 @@ protected void initFile(String id) throws FormatException, IOException {
Location omeMetaFile = new Location( zarrRootPath + File.separator + "OME", "METADATA.ome.xml" );
String canonicalPath = new Location(zarrRootPath).getCanonicalPath();

initializeZarrService(canonicalPath);
initializeZarrService();
reloadOptionsFile(zarrRootPath);

ArrayList<String> omeSeriesOrder = new ArrayList<String>();
Expand Down Expand Up @@ -445,7 +447,7 @@ private int[] get5DShape(int [] originalShape) {
* @param size of the shape required by jzarr
* @return a 5D shape to be used within the reader
*/
private int[] getOriginalShape(int [] shape5D, int size) {
private static int[] getOriginalShape(int [] shape5D, int size) {
int [] shape = new int[size];
int shape5DIndex = 4;
for (int s = shape.length - 1; s >= 0; s--) {
Expand All @@ -460,15 +462,15 @@ private int[] getOriginalShape(int [] shape5D, int size) {
public void reopenFile() throws IOException {
try {
String canonicalPath = new Location(currentId).getCanonicalPath();
initializeZarrService(canonicalPath);
initializeZarrService();
}
catch (FormatException e) {
throw new IOException(e);
}
}

protected void initializeZarrService(String rootPath) throws IOException, FormatException {
zarrService = new JZarrServiceImpl(rootPath);
dgault marked this conversation as resolved.
Show resolved Hide resolved
protected void initializeZarrService() throws IOException, FormatException {
zarrService = new JZarrServiceImpl(altStore());
openZarr();
}

Expand Down Expand Up @@ -1145,6 +1147,7 @@ protected ArrayList<String> getAvailableOptions() {
optionsList.add(LIST_PIXELS_KEY);
optionsList.add(QUICK_READ_KEY);
optionsList.add(INCLUDE_LABELS_KEY);
optionsList.add(ALT_STORE_KEY);
return optionsList;
}

Expand Down Expand Up @@ -1200,6 +1203,19 @@ public boolean includeLabels() {
}
return INCLUDE_LABELS_DEFAULT;
}

/**
* Used to provide the location of an alternative file store where the data is located
* @return String representing the root path of the alternative file store or null if no alternative location exist
*/
public String altStore() {
MetadataOptions options = getMetadataOptions();
if (options instanceof DynamicMetadataOptions) {
return ((DynamicMetadataOptions) options).get(
ALT_STORE_KEY, ALT_STORE_DEFAULT);
}
return ALT_STORE_DEFAULT;
}

private boolean systemEnvListPixels() {
String value = System.getenv(LIST_PIXELS_ENV_KEY);
Expand Down
Loading